985825 - Unprefix -moz-ethiopic-numeric

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P5)

Description

[Xidorn Quan [:xidorn] UTC+11]

-moz-ethiopic-numeric could be unprefixed since this counter style has been defined in CSS Counter Styles spec, and it seems to be working correctly.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8439877 [details] [diff] [review]
patch

Review of attachment 8439877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! A couple of (very minor) suggestions below.

::: layout/style/nsStyleConsts.h
@@ +654,5 @@
>  #define NS_STYLE_LIST_STYLE_SIMP_CHINESE_FORMAL   16
>  #define NS_STYLE_LIST_STYLE_TRAD_CHINESE_INFORMAL 17
>  #define NS_STYLE_LIST_STYLE_TRAD_CHINESE_FORMAL   18
>  #define NS_STYLE_LIST_STYLE_MOZ_TAMIL             19
> +#define NS_STYLE_LIST_STYLE_ETHIOPIC_NUMERIC      20

Maybe swap MOZ_TAMIL and ETHIOPIC_NUMERIC around, to match the order they're used in nsCSSProps.cpp? It shouldn't really matter, just seems tidier to me.

::: layout/style/test/property_database.js
@@ +2681,5 @@
>        "-moz-oriya", "-moz-kannada", "-moz-malayalam", "-moz-bengali",
>        "-moz-tamil", "-moz-telugu", "-moz-thai", "-moz-lao",
>        "-moz-myanmar", "-moz-khmer",
>        "-moz-hangul", "-moz-hangul-consonant",
> +      "-moz-ethiopic-halehame", "ethiopic-numeric",

Looking at the values here, the convention seems to be that the standard ones come first, and then the -moz-prefixed extras; which suggests moving ethiopic-numeric up among the standard values.

Also, should we keep the prefixed value here in addition to the non-prefixed? That seems to be what's been done for -moz-japanese-*, for example. WDYT?

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch, r=jfkthame

https://tbpl.mozilla.org/?tree=Try&rev=4ba413620f67

This patch should be applied after the patch for bug 982355.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3475bd79048

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3475bd79048

Comment 6

[Jean-Yves Perrier [:teoli]]

Doc updated: https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type
and
https://developer.mozilla.org/en-US/Firefox/Releases/33