Unprefix -moz-ethiopic-numeric

RESOLVED FIXED in mozilla33

Status

()

enhancement
P5
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks 2 bugs, {css3, dev-doc-complete})

Trunk
mozilla33
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
-moz-ethiopic-numeric could be unprefixed since this counter style has been defined in CSS Counter Styles spec, and it seems to be working correctly.
Assignee

Comment 1

5 years ago
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → quanxunzhen
Status: NEW → ASSIGNED
Attachment #8439877 - Flags: review?(jfkthame)
Comment on attachment 8439877 [details] [diff] [review]
patch

Review of attachment 8439877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! A couple of (very minor) suggestions below.

::: layout/style/nsStyleConsts.h
@@ +654,5 @@
>  #define NS_STYLE_LIST_STYLE_SIMP_CHINESE_FORMAL   16
>  #define NS_STYLE_LIST_STYLE_TRAD_CHINESE_INFORMAL 17
>  #define NS_STYLE_LIST_STYLE_TRAD_CHINESE_FORMAL   18
>  #define NS_STYLE_LIST_STYLE_MOZ_TAMIL             19
> +#define NS_STYLE_LIST_STYLE_ETHIOPIC_NUMERIC      20

Maybe swap MOZ_TAMIL and ETHIOPIC_NUMERIC around, to match the order they're used in nsCSSProps.cpp? It shouldn't really matter, just seems tidier to me.

::: layout/style/test/property_database.js
@@ +2681,5 @@
>        "-moz-oriya", "-moz-kannada", "-moz-malayalam", "-moz-bengali",
>        "-moz-tamil", "-moz-telugu", "-moz-thai", "-moz-lao",
>        "-moz-myanmar", "-moz-khmer",
>        "-moz-hangul", "-moz-hangul-consonant",
> +      "-moz-ethiopic-halehame", "ethiopic-numeric",

Looking at the values here, the convention seems to be that the standard ones come first, and then the -moz-prefixed extras; which suggests moving ethiopic-numeric up among the standard values.

Also, should we keep the prefixed value here in addition to the non-prefixed? That seems to be what's been done for -moz-japanese-*, for example. WDYT?
Attachment #8439877 - Flags: review?(jfkthame) → review+
Assignee

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=4ba413620f67

This patch should be applied after the patch for bug 982355.
Attachment #8439877 - Attachment is obsolete: true
Attachment #8440210 - Flags: review+
Assignee

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3475bd79048
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.