985857 - mach should default to logging to to a temp file

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

"./mach build" should by default log to a temp file of some sort, with ability to override this and not do so.  If there's some hard reason why not, then it should be possible to set an env var or some such to set a default log file.

Comment 1

[Gregory Szorc [:gps]]

What are you proposing? A "last log" file that can always be consulted after the build?

Do you want this for |mach build| or every mach command?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Yes, exactly, a last-log file (or if you prefer to think of it that way, a default for -l)

And for builds and mochitests I'd guess.  I can't count the times I went "darn, that compile failed, I'll have to repeat it while capturing a log".

Comment 3

[Mike Hommey [:glandium]]

I think a last-$command.log would be reasonable to have.

Comment 4

[Gregory Szorc [:gps]]

I agree with comment #3. And that makes this a bug in the mach core as opposed to a command thing.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Automatically log mach output and add a command to display it

I didn't go with comment 3 because i didn't feel like figuring out the right way to hook that with mach commands so that the name is part of the file name, or the how to make the show-log command useful in that mode.

Note that ideally, we'd have an actual start timestamp in the log, which we currently don't have. We should probably store a dummy even at startup for that. We should also store more things, like the log level, probably the format string to reproduce the log (or the format string should be implied by the action name, but that needs changing all calls to log()). But let's keep all that to followup bugs.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Automatically log mach output and add a command to display it

And don't fail to log after a clobber.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8615871 [details] [diff] [review]
Automatically log mach output and add a command to display it

Review of attachment 8615871 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good start and fit to land. Please file a follow-up to implement comment #3 and have logging on every command automatically (or at least provide a decorator or something so commands can be logged automatically.

Comment 9

[Mike Hommey [:glandium]]

> have logging on every command automatically (or at least provide a decorator or something so commands can be logged automatically.

Not sure what you mean here, since this patch is logging every command automatically, except it doesn't do so in separate files.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/632d018e4f26

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/632d018e4f26