985858 - Snapshots.cpp:411:21: warning: format string is not a string literal (potentially insecure) [-Wformat-security]

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning, introduced by bug 962555:
=============
js/src/jit/Snapshots.cpp:411:21: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
         fprintf(fp, ValTypeToString(p.type));
                     ^~~~~~~~~~~~~~~~~~~~~~~
=============

(I'm using clang 3.4 on Linux.)

Comment 1

[Daniel Holbert [:dholbert]]

IIRC we can fix this by adding
  "%s",
before the ValTypeToString invocation.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d51a9df37b8

Comment 4

[Boris Zbarsky [:bzbarsky]]

Or just fputs?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d51a9df37b8