Closed Bug 985954 Opened 8 years ago Closed 8 years ago

Remove deprecated promise.js usage in the testing framework

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

Attached patch The patchSplinter Review
The Add-on SDK Promises module is being deprecated in favor of Promise.jsm, so we're removing all references to it from mozilla-central.

This makes changes in the Promise object exposed by the testing framework, and adjusts tests consequently.

https://tbpl.mozilla.org/?tree=Try&rev=d4dd7a2df2a5
Attachment #8394142 - Flags: review?(ted)
Comment on attachment 8394142 [details] [diff] [review]
The patch

Feedback from Boris and Irving for test changes in the "content" folder and the Add-on Manager.
Attachment #8394142 - Flags: feedback?(irving)
Attachment #8394142 - Flags: feedback?(bzbarsky)
Comment on attachment 8394142 [details] [diff] [review]
The patch

Going to pass that off to someone who actually knows this test
Attachment #8394142 - Flags: feedback?(bzbarsky) → feedback?(rFobic)
Attachment #8394142 - Flags: feedback?(rFobic) → feedback+
Comment on attachment 8394142 [details] [diff] [review]
The patch

Review of attachment 8394142 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/browser/browser_cancelCompatCheck.js
@@ +187,5 @@
>    let deferred = Promise.defer();
>    var page = aWindow.document.getElementById(aPageId);
> +  if (aWindow.document.getElementById("updateWizard").currentPage === page) {
> +    deferred.resolve(aWindow);
> +  } else {

Ah, good catch. Thanks for finding & fixing this.
Attachment #8394142 - Flags: feedback?(irving) → feedback+
Comment on attachment 8394142 [details] [diff] [review]
The patch

Review of attachment 8394142 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. r=me assuming the other reviewers actually reviewed the test changes.
Attachment #8394142 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/8db4e655f7b9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
The following changeset is now in Firefox Nightly:

> 8db4e655f7b9 Bug 985954 - Remove deprecated promise.js usage in the testing framework. r=ted

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
Blocks: 996671
No longer blocks: 856878
You need to log in before you can comment on or make changes to this bug.