985971 - Incomplete tags cause (really) unexpected page rendering in Thimble

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Bobby Richter [:secretrobotron]]

STR:

1. Place "</" anywhere in the body of a Thimble make.

Expected result: Nothing; or, at most, some poorly formatted HTML.
Actual result: Some compiled CSS is written into the DOM, e.g. https://www.dropbox.com/s/4hbh0vs3eqi1nqs/Screenshot%202014-03-20%2015.36.51.png

Comment 1

[Brett Gaylor [:brett]]

wat

Comment 2

[Jon Buckley [:jbuck]]

That's the highlight css styles. Bobby, stop hacking us :(

Comment 3

[Bobby Richter [:secretrobotron]]

http://i.imgur.com/2skH3cE.gif

Comment 4

[Pomax]

it is indeed the highlight CSS, and the HTML preview should not be refreshed on broken HTML so the real bug is "preview updates content despite error in HTML"

Comment 5

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/404

STR: load thimble, type < somewhere, and have the error pop up. In current thimble, it'll update the preview loader. This patch prevents updates from happening when errors exist.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 8397133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/404

fun