Closed Bug 985991 Opened 10 years ago Closed 10 years ago

Loop Server —implement a redis store

Categories

(Hello (Loop) :: Server, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: rhubscher)

References

Details

Attachments

(2 files)

61 bytes, text/x-github-pull-request
alexis+bugs
: review-
Details | Review
55 bytes, text/x-github-pull-request
alexis+bugs
: review+
Details | Review
Sessions and Tokens from our provider will not be stored for a long period of time and should go into a specific in-memory store.

Elasticache seems the option here, which has different backends itself. We would need a connector to memcache here.
See https://www.npmjs.org/package/memcached
Assignee: nobody → rhubscher
After some discussions with ops, it seems clear we want to do that with memcached.
I'd like to use this https://www.npmjs.org/package/uber-cache and use their API.
https://github.com/serby/uber-cache-memcached as been landed.

I am changing loop-server to handle the new store API.
Attached file Link to GitHub PR.
So the next step was to have a helper that helps getting the cache backend from the configuration.
Attachment #8398616 - Flags: review?(alexis+bugs)
So, it actually seems that catbox already provide what we want, maybe we should just use it rather than reimplement it? https://github.com/spumko/catbox
Ok, I just released https://www.npmjs.org/package/uber-cache-helpers so that the work we did on it is not lost. And I told Paul Serby that we will use catbox. He should release uber-cache-memcached soon.
Attachment #8398616 - Flags: review?(alexis+bugs) → review-
I'm changing the name of this ticket since we want to use redis for everything and not memcache here.
Summary: Loop Server —implement a memcache store → Loop Server —implement a redis store
Attached file Link to GitHub PR.
Attachment #8405046 - Flags: review?(alexis+bugs)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified in code and verified the work on the OPs side...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: