985991 - Loop Server —implement a redis store

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

Sessions and Tokens from our provider will not be stored for a long period of time and should go into a specific in-memory store.

Elasticache seems the option here, which has different backends itself. We would need a connector to memcache here.

Comment 1

[Rémy Hubscher (:natim)]

See https://www.npmjs.org/package/memcached

Comment 2

[Alexis Metaireau (:alexis)]

After some discussions with ops, it seems clear we want to do that with memcached.

Comment 3

[Rémy Hubscher (:natim)]

I'd like to use this https://www.npmjs.org/package/uber-cache and use their API.

Comment 4

[Rémy Hubscher (:natim)]

https://github.com/serby/uber-cache-memcached as been landed.

I am changing loop-server to handle the new store API.

Comment 5

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

So the next step was to have a helper that helps getting the cache backend from the configuration.

Comment 6

[Alexis Metaireau (:alexis)]

So, it actually seems that catbox already provide what we want, maybe we should just use it rather than reimplement it? https://github.com/spumko/catbox

Comment 7

[Rémy Hubscher (:natim)]

Ok, I just released https://www.npmjs.org/package/uber-cache-helpers so that the work we did on it is not lost. And I told Paul Serby that we will use catbox. He should release uber-cache-memcached soon.

Comment 8

[Alexis Metaireau (:alexis)]

I'm changing the name of this ticket since we want to use redis for everything and not memcache here.

Comment 9

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

Comment 10

[Alexis Metaireau (:alexis)]

Comment on attachment 8405046 [details] [review]
Link to GitHub PR.

https://github.com/mozilla-services/loop-server/commit/130d944d116f522adac8a3e975242883b22fa10f

Comment 11

[James Bonacci [:jbonacci]]

Verified in code and verified the work on the OPs side...