986003 - CSS color validation generates many messages in the error console

Status: RESOLVED DUPLICATE of bug 1111601

(DevTools :: Inspector, defect)

Description

[Dave Townsend [:mossop]]

The error console of the devtools test is littered with errors like this:

Console message: [JavaScript Warning: "XUL box for span element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/layoutview/view.xhtml" line: 0}]

Sometimes a dozen at a time. This makes the test output difficult to read and I can't imagine it does good things for our speed.

The cause is this function trying to test if any css string it encounters is a color: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/css-color.js#377

Is there a reason we don't use DOMUtils.colorNameToRGB to do the validation here?

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Dave Townsend (:Mossop) from comment #0)
> Is there a reason we don't use DOMUtils.colorNameToRGB to do the validation
> here?

It was because we needed to be able to validate any color type accepted by the browser. Of course, it would be great if we could do this without using hiddenWindow.

Comment 2

[Tom Tromey :tromey]

I think this has since been fixed.  css-color.js no longer uses a hidden window
and now uses inIDOMUtils.isValidCSSColor.  This happened in bug 1111601.
So, I'm closing this as a dup of that.