Closed Bug 986080 Opened 6 years ago Closed 6 years ago

TypeError: stagingDirEntries is null at resource://gre/modules/addons/XPIProvider.jsm:2279

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: Irving, Assigned: Irving)

References

Details

Attachments

(1 file)

Another issue from exception telemetry. If for any reason we can't iterate the XPI staging directory, XPIProvider.jsm:getDirectoryEntries() returns null (and doesn't close its directory enumerator), but none of the callers check for null.
(I was wrong about not closing the iterator, though we did try to close it even if we fail to get one)

Rather than spread the null check around to all the callers, I just return an empty array, since there's not much interesting the callers could do with knowledge of the failure.
Assignee: nobody → irving
Status: NEW → ASSIGNED
Attachment #8394329 - Flags: review?(dtownsend+bugmail)
Attachment #8394329 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/29d33fe0614c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.