Closed
Bug 986080
Opened 11 years ago
Closed 11 years ago
TypeError: stagingDirEntries is null at resource://gre/modules/addons/XPIProvider.jsm:2279
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Irving, Assigned: Irving)
References
Details
Attachments
(1 file)
|
1.57 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Another issue from exception telemetry. If for any reason we can't iterate the XPI staging directory, XPIProvider.jsm:getDirectoryEntries() returns null (and doesn't close its directory enumerator), but none of the callers check for null.
|
Assignee | |
Comment 1•11 years ago
|
||
(I was wrong about not closing the iterator, though we did try to close it even if we fail to get one)
Rather than spread the null check around to all the callers, I just return an empty array, since there's not much interesting the callers could do with knowledge of the failure.
Assignee: nobody → irving
Status: NEW → ASSIGNED
Attachment #8394329 -
Flags: review?(dtownsend+bugmail)
|
||
Updated•11 years ago
|
Attachment #8394329 -
Flags: review?(dtownsend+bugmail) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•