The default bug view has changed. See this FAQ.

TypeError: stagingDirEntries is null at resource://gre/modules/addons/XPIProvider.jsm:2279

RESOLVED FIXED in mozilla31

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Irving, Assigned: Irving)

Tracking

unspecified
mozilla31
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Another issue from exception telemetry. If for any reason we can't iterate the XPI staging directory, XPIProvider.jsm:getDirectoryEntries() returns null (and doesn't close its directory enumerator), but none of the callers check for null.
Created attachment 8394329 [details] [diff] [review]
Don't return null from getDirectoryEntries

(I was wrong about not closing the iterator, though we did try to close it even if we fail to get one)

Rather than spread the null check around to all the callers, I just return an empty array, since there's not much interesting the callers could do with knowledge of the failure.
Assignee: nobody → irving
Status: NEW → ASSIGNED
Attachment #8394329 - Flags: review?(dtownsend+bugmail)
Attachment #8394329 - Flags: review?(dtownsend+bugmail) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/29d33fe0614c
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/29d33fe0614c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.