986102 - [Camera][Madai][Mozilla][UX] 1.4 Remove play icon from image preview thumbnail

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: screen.png

Please remove play icon from image preview thumbnail (see attached). Thanks!

Comment 1

[Justin D'Arcangelo [:justindarc]]

This will need to be addressed by 971090 since the code responsible for drawing the "Play" icon has been moved to accommodate the new gallery preview. Setting NEEDINFO for Hyuna so she is aware of this.

Comment 2

[hyuna.cho]

Attachment: PR-986102

Comment 3

[Diego Marcos [:dmarcos]]

This one looks good

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8394618 [details]
PR-986102

If the arrow drawing code is removed, the context.save() call on line 58 and the corresponding context.restore() call on lines 89-91 are no longer needed. Please remove those before landing.

Also, the video argument is no longer necessary, so please remove that and remove it from everywhere the function is called.  

If this was a last minute blocking change that had to go in ASAP, I'd be okay with a minimal patch (just setting video to false at the call site).  But if we're going to remove unused code, we ought to do it right and remove all of it.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Yeah, I was never a fan of the fact that we were programmatically drawing the play icon onto the thumbnails in the first place. I'm glad we're removing this.

Comment 6

[Justin D'Arcangelo [:justindarc]]

This has been resolved with the landing of camera-new-features to master:

https://github.com/mozilla-b2g/gaia/commit/e328318d5e27a3253061fb1679ab9abc82e60fcc

Comment 7

[sarsenyev]

As per comment 6, the bug is fixed on master and 1.4 builds.
The "Play" icon is removed from "Preview" thumbnail

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140409000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: e450e07e3a58
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 Master
BuildID: 20140409040202
Gaia: 650e8c2c611ed07495d3bf3769f44a0efd88a492
Gecko: 5811efc11011
Version: 31.0a1
Firmware Version: v1.2-device.cfg