986147 - [GGC] On Maple jsreftests: Assertion failure: !(*thingp)->arenaHeader()->allocatedDuringIncremental

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

See eg https://tbpl.mozilla.org/?tree=Maple&rev=8fe4b56c9537

Mostly happens on Windows, but OSX got it too. Logs:

https://tbpl.mozilla.org/php/getParsedLog.php?id=36458897&tree=Maple
https://tbpl.mozilla.org/php/getParsedLog.php?id=36462268&tree=Maple
https://tbpl.mozilla.org/php/getParsedLog.php?id=36461005&tree=Maple
https://tbpl.mozilla.org/php/getParsedLog.php?id=36461220&tree=Maple

Error:

INFO -  Assertion failure: !(*thingp)->arenaHeader()->allocatedDuringIncremental, at /builds/slave/map-osx64-d-000000000000000000/build/js/src/gc/Marking.cpp:364
WARNING -  TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Math/atanh-approx.js | Exited with code 1 during test run

0  XUL!js::gc::IsAboutToBeFinalized<js::ArrayBufferViewObject> [Marking.cpp:8fe4b56c9537 : 339 + 0x0]
1  XUL!js::gc::IsObjectAboutToBeFinalized(js::ArrayBufferViewObject**) [Marking.cpp:8fe4b56c9537 : 459 + 0x4]
2  XUL!js::ArrayBufferObject::sweep(JSCompartment*) [ArrayBufferObject.cpp:8fe4b56c9537 : 820 + 0x4]
3  XUL!js::Nursery::collect(JSRuntime*, JS::gcreason::Reason, js::Vector<js::types::TypeObject*, 0ul, js::SystemAllocPolicy>*) [Nursery.cpp:8fe4b56c9537 : 769 + 0x7]
4  XUL!Collect [jsgc.cpp:8fe4b56c9537 : 5102 + 0x12]
5  XUL!nsJSContext::GarbageCollectNow(JS::gcreason::Reason, nsJSContext::IsIncremental, nsJSContext::IsCompartment, nsJSContext::IsShrinking, long long) [nsJSEnvironment.cpp:8fe4b56c9537 : 1850 + 0x11]
6  XUL!nsTimerImpl::Fire() [nsTimerImpl.cpp:8fe4b56c9537 : 551 + 0x9]

Comment 1

[Terrence Cole [:terrence]]

Attachment: allow_isabouttobefinalized_during_minorgc-v0.diff

r=sfink via IRC.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7cc3196d216

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7cc3196d216