986195 - test_jsctypes.js xpcshell test fails in Windows 64-bit builds | "expected Error exception, none thrown"

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Example failure:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=36287210&tree=Date

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

Making the code match the comment. Super happy that the comment exists, by the way :)

Comment 2

[Robert Strong (they/them - no direct email)]

One more down... awesome and thanks!

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8394437 [details] [diff] [review]
Patch v1

Tested locally with win64 and win32 builds. Both passed the test_jsctypes.js test (when previously the win64 build would fail)

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8394437 [details] [diff] [review]
Patch v1

Review of attachment 8394437 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding and fixing my mistake!

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v2

Updating patch to contain "r=froydnj"

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Setting checkin-needed (no need to land this separately and waste build resources)

Comment 7

[Carsten Book [:Tomcat]]

landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/3f28447213aa

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f28447213aa