986276 - [Camera] [Madai][UX] Indicator should disappear when recording video

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

The indicators are not providing any useful information when recording video. Better to hide them to reduce clutter

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: Pull Request Camera New Features

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8394526 [details] [review]
Pull Request Camera New Features

I actually disagree with this patch because we will soon land the low-battery code and there will be a battery indicator visible all the time when the battery is low.  I think this having a low battery indicator during video recording is actually one of our user stories for this release!

So you could do a patch that hid some of the indicators during recording, but not all. In any case, it seems like a polish thing to deal with after we address the actualy bugs that have been reported.

Comment 3

[Diego Marcos [:dmarcos]]

If low battery is important information to communicate to the user it should be something more noticeable that the small indicator icons. It can be easily missed.

Comment 4

[Diego Marcos [:dmarcos]]

Modified the patch to hide individual indicators: hdr and self timer

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8394526 [details] [review]
Pull Request Camera New Features

Looks good to me, though I haven't actually tested it.  Assuming you have.

The indicators CSS now relies on three different visibility mechanisms: opacity, display and visibility.  Seems like it works, but I wish there was a cleaner way.  

But I'm not suggesting you spend any more time on this, since it is not in any sense a blocker bug.

Comment 6

[Diego Marcos [:dmarcos]]

Landed in camera-new-features:

https://github.com/mozilla-b2g/gaia/commit/ad5a232980e427830fe272198052b858110960ba

Comment 7

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 8

[sarsenyev]

The bug is no longer reproduces on the latest 1.4 and master builds
Indicator disappears when recording video


1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri Master 
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg