986400 - Sync does not start in SeaMonkey 2.28a1

Status: RESOLVED FIXED

(SeaMonkey :: Sync UI, defect)

Description

[H. Hofer]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Firefox/31.0 SeaMonkey/2.28a1 (Beta/Release)
Build ID: 20140320003001

Steps to reproduce:

Starting SeaMonkey (or manually triggering a sync)


Actual results:

An error message in the log:
> Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
> Source File: resource://gre/modules/services-sync/browserid_identity.js
> Line: 23

The offending line is:
> Cu.import("resource://gre/modules/FxAccounts.jsm");


Expected results:

The 'FxAccounts.jsm' and dependent modules should have been included in 'omni.ja'

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

I wonder how FF packages the missing file. The only place of reference I could find was /mozilla/services/fxaccounts/moz.build. Nothing in any package-manifest.in.

Comment 2

[Philip Chee]

I have a patch, building now.

Comment 3

[Philip Chee]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> I wonder how FF packages the missing file. The only place of reference I
> could find was /mozilla/services/fxaccounts/moz.build. Nothing in any
> package-manifest.in.
It's in suite/confvars.sh we need to port the change from mozilla/browser/confvars.sh

Comment 4

[Philip Chee]

Attachment: Patch v1.0 One line fix.

One line fix from https://hg.mozilla.org/mozilla-central/rev/806f7c40cccf#l8.12

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8395420 [details] [diff] [review]
Patch v1.0 One line fix.

Review of attachment 8395420 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern here is that we don't actually have UX/UI around "Firefox Accounts" and merely around "Sync" two different backends entirely. I Know we want "<> Accounts" working of course.

Comment 6

[Philip Chee]

(In reply to Justin Wood (:Callek) from comment #5)

> my only concern here is that we don't actually have UX/UI around "Firefox
> Accounts" and merely around "Sync" two different backends entirely. I Know
> we want "<> Accounts" working of course.

I intend to get our Sync UI updated, then I'll look into FxAccounts (or would it be SmAccounts?)

Comment 7

[Philip Chee]

I pushed to comm-central:
comm-central changeset 28b75077c9ef
http://hg.mozilla.org/comm-central/rev/28b75077c9ef