986427 - GET /calls/ doesn't work - always returns '{ "error": "missing: version" }'

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Mark Banner (:standard8)]

GET /calls/ needs a version parameter, however even when doing a http://localhost:5000/calls?version=0 request, it returns 400, with:

{ "error": "missing: version" }

From reading the code, it looks like it expects the values to be in the JSON body, but that isn't valid.

Comment 1

[Mark Banner (:standard8)]

It also requires the Content-Type to be application/json, and I'm not sure that that is really necessary.

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8394726 [details] [review]
Link to GitHub PR.

Looks good, and works locally. r=Standard8

Comment 4

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/85a3ccade0e7dbfbb95ab308e6f113db8e4c2c94

Comment 5

[James Bonacci [:jbonacci]]

Verified in code and through unit tests.