986452 - browser_net_timing-division.js leaks 1 window until shutdown

Status: NEW

(DevTools :: Netmonitor, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

while running tests per directory instead of a massive chunk, I find that browser_net_timing-division.js leaks 1 window until shutdown on all platforms all the time!

here is a link to the try server run:
https://tbpl.mozilla.org/?tree=Try&rev=29bcc82f7302

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

after disabling browser_net_timing-division.js, I get a new failure in browser_net_timeline_ticks.js:
https://tbpl.mozilla.org/?tree=Try&rev=92e0ebab5925

I suspect there is a leak somewhere and the last test in the suite is the scapegoat.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

ok, after doing this many times, I have found that I just need to disable every single test in this suite as at least 50% of the time each test will leak.  Obviously there isn't a lot of interest in this bug- disabling this entire directory of tests is an easy way to move forward.

Comment 3

[Girish Sharma [:Optimizer]]

In bug 986467, I found that the tests are not an issue, but lack of proper GC and tests running too fast for things to be cleaned up in time.

Can you try adding couple of GC calls after each test ?

This might fix many other similar leaking bugs.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This is biting us on Cedar now with mochitest-dt split into 2 chunks, which means it's now blocking us enabling this work in production.
https://tbpl.mozilla.org/php/getParsedLog.php?id=37282540&tree=Cedar