Closed Bug 986458 Opened 7 years ago Closed 6 years ago

browser_whitelist7.js leaked 1 docShell(s) until shutdown on all platforms in debug mode when run as a standalone directory

Categories

(Firefox for Android Graveyard :: Add-on Manager, defect)

defect
Not set
normal

Tracking

(firefox29 unaffected, firefox30 unaffected, firefox31 disabled, firefox41 fixed, firefox-esr24 unaffected)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox29 --- unaffected
firefox30 --- unaffected
firefox31 --- disabled
firefox41 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: jmaher, Assigned: esawin)

References

Details

Attachments

(1 file)

I am working to chunk the browser-chrome tests better, this requires us to run directory by directory instead of a big chunk of tests.  one side effect is that many tests fail and this is one of the lucky tests.

here is a try server run showing the failures:
https://tbpl.mozilla.org/?tree=Try&rev=29bcc82f7302

all platforms on debug we leak.
I am going to try removing this line:
http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpinstall/browser_whitelist7.js#25

as this would make it identical to whitelist4.js.
The leaking test is testing an Android feature on the desktop path, since we are only concerned with the shared blocking mechanics. The desktop front-end, however, does not handle blocked direct requests well, so we need to default to |localhost| when no host is available there.

Lets test this patch. Should it fix the issue, we need to decide whether this is something we want to handle with an appropriate warning prompt on desktop, like we do it on Android.
I tested this patch and I still see it leaking:
https://tbpl.mozilla.org/?tree=Try&rev=99b14959adca

So quite possibly this is a leak in other tests in that directory that is getting blamed on whitelist7
We're seeing this on Cedar as well and it's one of the few remaining issues that's blocking us getting chunking enabled across all platforms. Any other ideas, Eugen?

https://tbpl.mozilla.org/php/getParsedLog.php?id=37281982&tree=Cedar
Flags: needinfo?(esawin)
The Try server push from comment 4 is the unpatched version, can we test this patch on the failing systems (Win 8 debug, OS X debug) to see if it helps? Here are the tests on the patched Cedar branch, but Try doesn't run the bc3 chunks on the failing systems: https://tbpl.mozilla.org/?tree=Try&rev=71acd51217d2.
Flags: needinfo?(ryanvm)
Flags: needinfo?(jmaher)
Flags: needinfo?(esawin)
Just realized that the bc tests aren't chunked on those systems yet, queuing some more bc runs on the patched version: https://tbpl.mozilla.org/?tree=Try&rev=71acd51217d2.
Flags: needinfo?(ryanvm)
Flags: needinfo?(jmaher)
FWIW, disabling browser_whitelist7.js does make the bc3 leaks go away, but we still do see other intermittent failures in the xpinstall tests like this:
https://tbpl.mozilla.org/php/getParsedLog.php?id=37334205&tree=Cedar
any other thoughts here?  Should we keep this disabled for now until?  We can keep trying patches on cedar.

Our goal is to have everything ready for the firefox31 branches by Friday.
Let's keep this test disabled for now. It should be more convenient to test patches for it with chunking enabled across all platforms.
Disabled on Windows and OSX debug.
https://hg.mozilla.org/integration/fx-team/rev/6c260ce33c2a
Assignee: nobody → ryanvm
Whiteboard: [test disabled on OSX and Windows debug][leave open]
Assignee: ryanvm → esawin
Does not leak when enabled on m-c: https://tbpl.mozilla.org/?tree=Try&rev=3dc2f2560d1b.
Should we enable the test but keep this bug open for now?
Yeah, that's worrying to me because chunk-by-dir was supposed to give us more consistent results.
chunk-by-dir will reduce the problems when we add/disable a test as they won't switch chunks- that same effect can still cause tests in the same chunk to have problems.
This appears to have gone away on its own. Re-enabling the test across the board.
https://hg.mozilla.org/integration/mozilla-inbound/rev/10e08248da4f
Whiteboard: [test disabled on OSX and Windows debug][leave open]
https://hg.mozilla.org/mozilla-central/rev/10e08248da4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.