986481 - Expose Promise.jsm as a devtools loader global

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[:Paolo Amadini]

Attachment: The patch

Panos, this is your patch for landing. It looks good to me and has green try:

https://tbpl.mozilla.org/?tree=Try&rev=8d13ed4c0b4d

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8394779 [details] [diff] [review]
The patch

Review of attachment 8394779 [details] [diff] [review]:
-----------------------------------------------------------------

I feel weird reviewing my own patch, let's get someone else to do it :-)

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8394779 [details] [diff] [review]
The patch

I am going to defer this (heh. "defer", get it?) to dcamp since it's a loader thing.

Comment 3

[Dave Camp (:dcamp)]

Can you explain why we're doing this?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

My original suggestion is in bug 943517 comment 8, but to recap, we want to convert from (sync) sdk promises to (async) Promise.jsm promises, which among other benefits provides a better path forward to ES6 promises. At the same time, we want to make the debugger server not use the mozIJSSubScriptLoader in order to be used for debugging workers (bug 859372). Also, we need to load the promise library in the server's global in order to avoid breaking stepping with chrome debugging.

Pre-loading the promise library in the loader's globals achieves those goals and simplifies upgrading to native promises to a 2-line patch.

Comment 5

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/b086a61f4cfc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b086a61f4cfc