98650 - Can't get mail from an specific account

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Gabriel Cabillón]

From Bugzilla Helper:
User-Agent: Mozilla/4.78 [en] (Win98; U)
BuildID:    2001090503

When I try to fetch the mail from one account, it shows activity in the mozilla 
icon to the top-right, and the progress bar shows activity for a while, and then 
it says "Document: Done" without anything else showing up. Never ask for 
password. 

Other pop3 accounts works nicely.
On Netscape 4.7x works fine
On Mozilla 0.9.3 for Linux, Netscape 6.0/6.1 for Linux & Windows, same problem.

I created an account on the problematic server for testing porpose :
user: mozilla
passwd: moz123
pop server: adinet.com.uy
port: 110



Reproducible: Always
Steps to Reproduce:
1. Setup the pop mail account
2. Get mail

Actual Results:  Don't fetch mail

Many OS: Windows 98, Windows 2000, SuSE Linux 7.2 kernel 2.4.4.
All with Netscape 4.7x already installed, creating the profile from zero and/or 
converting it.

Comment 1

[Matthias Versen [:Matti]]

confirming with win2k build 20010906..
This works with NS4.75DE but not with mozilla.

Reporter: 
Thanks for the test Account. We could not test this without this Account but
please don't close the Account unless the developer looked at this bug !

Comment 2

[Matthias Versen [:Matti]]

NSPR pop3 log :

0[354a60]: Entering NET_ProcessPop3 55
0[354a60]: POP3: Entering state: 1
0[354a60]: POP3: Entering state: 2
0[354a60]: POP3: Entering state: 4
0[354a60]: RECV: +OK POPDIST (version 1.00) at adinet.com.uy starting.
0[354a60]: POP3: Entering state: 29
0[354a60]: SEND: AUTH
0[354a60]: Entering NET_ProcessPop3 39
0[354a60]: POP3: Entering state: 3

Comment 3

[Navin Gupta]

Attachment: proposed fix

Comment 4

[Navin Gupta]

The fix is to just look for linefeed '\n' char for end-of-line. This is how 4x 
also read lines. Since we have to look for just one char I have changed 
PL_strstr to PL_strchr. This should speed up all protocols in mail/news. I have 
tested the patch on linux and win32, will test on mac as well before committing. 

Comment 5

[Navin Gupta]

I tested on mac as well and the patch works.

Comment 6

[Navin Gupta]

This has r/sr=mscott.

Comment 7

[Scott MacGregor]

sr=mscott

Comment 8

[Navin Gupta]

fix checked in. stephend, this checkin should make all the protocols where 
reading incoming buffer data is involved faster,  if interested, you may measure
the gain. 

Comment 9

[Sheela Ravindran]

change qa contact to stephend since this is a code fix.

Comment 10

[Navin Gupta]

This is not a code fix. Please read carefully. 

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

back to Sheela.  I'll be testing the perf gains on IMAP tomorrow.

Comment 12

[Sheela Ravindran]

build:  2001-09-12-05 trunk. I was able to see reproduce this problem using a 
old trunk build before the fix.
I am still using this account to test and not yet done verifying this bug. 
So reporter please don't close this account till I verify this bug. Thanks.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

See http://www.mozilla.org/mailnews/win_performance_results.html and the links 
for each platform off that page for more info:

Okay, I'm not verifying this from a code or even usage standpoint, but from the 
performance perspective, this helped:

Platform: Windows:

Build          |     Folder Loading Speed Time
----------------------------------------------
2001-09-14     |    1.95   (2.46 1.69 1.75)
2001-09-21     |    1.79   (2.46 1.46 1.47)     

So, around 15-20 milliseconds faster.

Linux

Build          |     Folder Loading Speed Time
----------------------------------------------
2001-09-14     |     3.05 (4.13 2.61 2.40) 
2001-09-21     |     2.34 (2.99 2.02 2.01)

So, around 30 milliseconds here.

Sorry, haven't complete Mac yet.

Comment 14

[Sheela Ravindran]

verified using 2001-09-25-05 trunk build on win98. Can get messages from this 
account