986584 - Use the new OS X buttons

Status: RESOLVED FIXED

(Calendar :: General, defect, P2)

Description

[Richard Marti (:Paenglab)]

Bug 980491 introduced a new button appearance. This bug is to follow on Lightning.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Thanks for filing. This needs to be done before TB31, I see that in the event dialog the icons are currently stretched.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch

There's not much to change but is saves some bytes with the removed checked images.

The calendar-status-todaypane-button has now also a border and looks in checked state like the QFB button. This makes the status-bar 2px taller but the status-bar is on my system still not a tall as the Finder staus-bar. So I think this should be okay like this.

The icons are now a bit squezed but this will be fixed with bug 985595.

Comment 3

[Richard Marti (:Paenglab)]

I asked for approval-calendar-aurora because the TB patch is also in Aurora.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8394934 [details] [diff] [review]
patch

Review of attachment 8394934 [details] [diff] [review]:
-----------------------------------------------------------------

r/a=philipp

::: calendar/lightning/themes/osx/lightning.css
@@ +104,5 @@
> +#calendar-status-todaypane-button[checked="true"]:hover {
> +  border-color: hsla(0, 0%, 0%, .2);
> +  background: hsla(0, 0%, 100%, .1) linear-gradient(hsla(0, 0%, 100%, .3),
> +              hsla(0, 0%, 100%,.1)) padding-box;
> +  box-shadow: 0 1px 0 hsla(0, 0%, 100%, .5), 0 1px 0 hsla(0, 0%, 100%, .5) inset;

Is there a way we can just use a class provided by Thunderbird? On the one hand it would avoid us needing to make changes in the future, on the other side we might make it look weird on Seamonkey.

What do you think?

Comment 5

[Richard Marti (:Paenglab)]

I think we could try .toolbabutton-1 but this should be done in a new bug as it also needs some tweaks on Linux and Windows.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/46b7123a670d
https://hg.mozilla.org/releases/comm-aurora/rev/a7da345bcc87