986590 - Confusing error message when not finding reviewer

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Ángel]

When the provided reviewer is wrong, bugzilla always shows the message «You must provide a reviewer for review requests.» despite the field being filled.


Steps to reproduce:
- Create a new attachment and set review to ?
- Fill the with a wrong developer email, such as [e-mail] when it should have been [e-mail] (I stumbled upon this using a «wrong email» I got from the hg log)
- Bugzilla simply answers «You must provide a reviewer for review requests.»… which you did provide.


Expected behavior:
- If there's no entry in the reviewer field «You must provide a reviewer for review requests.»
- If the reviewer field doesn't contain a @: «You must identify the reviewer with his email address.»
- If the email address is not found in bugzilla: «The reviewer [e-mail] is not a valid bugzilla user.»

Comment 1

[David Lawrence [:dkl]]

This is an issue with the Review extension which is specific to BMO. Moving.

Comment 2

[:glob ✱]

Attachment: 986590_1.patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8395515 [details] [diff] [review]
986590_1.patch

Review of attachment 8395515 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 4

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   3351341..f8a258d  4.2 -> 4.2