Closed
Bug 986590
Opened 11 years ago
Closed 11 years ago
Confusing error message when not finding reviewer
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mozilla, Unassigned)
Details
Attachments
(1 file)
1.13 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
When the provided reviewer is wrong, bugzilla always shows the message «You must provide a reviewer for review requests.» despite the field being filled.
Steps to reproduce:
- Create a new attachment and set review to ?
- Fill the with a wrong developer email, such as foo@example.com when it should have been foo@mozilla.com (I stumbled upon this using a «wrong email» I got from the hg log)
- Bugzilla simply answers «You must provide a reviewer for review requests.»… which you did provide.
Expected behavior:
- If there's no entry in the reviewer field «You must provide a reviewer for review requests.»
- If the reviewer field doesn't contain a @: «You must identify the reviewer with his email address.»
- If the email address is not found in bugzilla: «The reviewer foo@example.com is not a valid bugzilla user.»
Comment 1•11 years ago
|
||
This is an issue with the Review extension which is specific to BMO. Moving.
Assignee: ui → nobody
Component: User Interface → Extensions: Review
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production
Attachment #8395515 -
Flags: review?(dkl)
Comment 3•11 years ago
|
||
Comment on attachment 8395515 [details] [diff] [review]
986590_1.patch
Review of attachment 8395515 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8395515 -
Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
3351341..f8a258d 4.2 -> 4.2
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Extensions: Review → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•