986627 - Allow to find which builders have changed before/after a patch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

I already have something have baked.
Once it is clean I will post it for review.

Comment 1

[Steve Fink [:sfink] [:s:]]

I use bug 914813 for this. It dumps out a brief description of each builder as well as a full config dump. test-masters --diff compares each of the brief ones, and if they match, it diffs the full ones.

But if you just want to diff the list of builders, bug 914813 is obviously total overkill.

Comment 2

[Armen [:armenzg]]

Just difference on builders.
Thanks for pointing that bug out!

Comment 3

[Armen [:armenzg]]

jgriffin also believes this has value. I'm resurrecting it.

Comment 4

[Armen [:armenzg]]

Hi catlee,
I have created a bash script that creates build, test and try masters and diffs the list of builders for each one of them.
This allows someone working on buildbot-configs to add/remove builders to determine if they're in the right direction.

Does this approach work for you?

I also create this community_masters.json file to help me create the masters.
[{
    "enabled": true,
    "environment": "staging",
    "hostname": "localhost",
    "http_port": 8010,
    "name": "build_master",
    "pb_port": 9010,
    "role": "build",
    "ssh_port": 7010
},
{
    "enabled": true,
    "environment": "staging",
    "hostname": "localhost",
    "http_port": 8011,
    "name": "try_master",
    "pb_port": 9011,
    "role": "try",
    "ssh_port": 7011
},
{
    "enabled": true,
    "environment": "staging",
    "hostname": "localhost",
    "http_port": 8021,
    "name": "test_master",
    "pb_port": 9021,
    "role": "tests",
    "ssh_port": 7021
}]

Comment 5

[Armen [:armenzg]]

Attachment: buildbot.diff

I took the approach you mentioned on IRC.
This does the trick.

You will notice some funkiness inside of the venv that we will need to fix once we check in the requirements file.

If you notice, in the requirements file I have skipped the buildbot requirement as I immediately follow to install it from the releng buildbot repo.

Comment 6

[Armen [:armenzg]]

On another note, I did not know how to easily separate the functionality of setting buildbot up from the functionality of diffing. I'm open to suggestions as bash is not my forte.

Comment 7

[Armen [:armenzg]]

https://hg.mozilla.org/build/braindump/rev/eaeebcebdf07