986636 - question mark that appears when password sync is disabled due to master password should be an image

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 970167 added an explanatory link, but it would be nicer for this to be an image of a questionmark. I think we have one of those around somewhere...

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Mark, if you want this change to be in 29, please provide a patch this week. Thanks :)

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-986636-use-icon-instead-of-on-sync-prefs-when-ma.patch

It seems chrome://global/skin/icons/question-16.png is a reasonable image to use.  I've only tested this on Windows.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8403820 [details] [diff] [review]
0001-Bug-986636-use-icon-instead-of-on-sync-prefs-when-ma.patch

Review of attachment 8403820 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that looks much better!

::: browser/themes/osx/preferences/preferences.css
@@ +235,5 @@
>  }
>  
> +#fxa-pweng-help-link > image {
> +  list-style-image: url("chrome://global/skin/icons/question-16.png");
> +}

Make that:

#fxa-pweng-help-link > image {
  width: 16px;
  height: 16px;
  list-style-image: url("chrome://global/skin/icons/question-16.png");
}

@media (min-resolution: 2dppx) {
  #fxa-pweng-help-link > image {
    list-style-image: url("chrome://global/skin/icons/question-32.png");
  }
}

And everything looks fine on Retina, too :)

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/6a39967bd426

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8403820 [details] [diff] [review]
0001-Bug-986636-use-icon-instead-of-on-sync-prefs-when-ma.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA Sync
User impact if declined: Sync prefs pane is ugly!
Testing completed (on m-c, etc.): Landed on fx-team and green there.
Risk to taking this patch (and alternatives if risky): Low risk, limited to
sync
String or IDL/UUID changes made by this patch: None

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a39967bd426

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24003d51424d
https://hg.mozilla.org/releases/mozilla-beta/rev/785fb5b58ae5

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I've verified the fix on Win 7 x64, Mac OS X 10.9.2, Ubuntu 13.04 x64, using Firefox 29 Beta 8 (BuildID: 20140414143035), latest 30.0a2 Aurora (BuildID: 20140415004003) and latest 31.0a1 Nightly (BuildID: 	20140415030203). The new question mark image from chrome://global/skin/icons/question-16.png is displayed.