986932 - DevTools - Some items in options panel are misaligned

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Tim Nguyen :ntim]

Screenshot : http://images.devs-on.net/Image/K2i2BCxb9AqyISnh-Region.png

Patch coming right away.

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: options-panel-osx.png

You can see that the margin:0 squeezes these two elements together on OSX

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8395401 [details] [diff] [review]
Patch

Review of attachment 8395401 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this is for overriding some UA styles on Windows.  However, this causes some issues on OSX (see https://bugzilla.mozilla.org/attachment.cgi?id=8396376).  My suggestion would be to find the most specific UA styles that are causing problems (probably a margin-left based on this issue) and override just that.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8395401 [details] [diff] [review]
Patch

Review of attachment 8395401 [details] [diff] [review]:
-----------------------------------------------------------------

Also, could you add r=bgrins to the end of the commit message when you upload the next patch?

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch v2

This should fix the issue.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #5)
> Created attachment 8396467 [details] [diff] [review]
> Patch v2
> 
> This should fix the issue.

This looks good on OSX.  I've pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=08e1e0107ffb, so that I can check on Linux (I'm assuming that it looks correct on Windows since that is what you are using).

Comment 7

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #6)
> (In reply to Tim Nguyen [:ntim] from comment #5)
> > Created attachment 8396467 [details] [diff] [review]
> > Patch v2
> > 
> > This should fix the issue.
> 
> This looks good on OSX.  I've pushed to try:
> https://tbpl.mozilla.org/?tree=Try&rev=08e1e0107ffb, so that I can check on
> Linux (I'm assuming that it looks correct on Windows since that is what you
> are using).

How do try builds work ? (I'm new at Firefox developing).

Comment 8

[Brian Grinstead [:bgrins]]

> How do try builds work ? (I'm new at Firefox developing).

It runs a build in the same way as if you landed it (building and testing it).  Usually we use it to run the test suites and make sure a patch didn't break anything.  In this case, once the "B" turns green in the interface next to Linux, that means the build has finished and we can go to the build directory to grab binaries to run.

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #8)
> > How do try builds work ? (I'm new at Firefox developing).
> 
> It runs a build in the same way as if you landed it (building and testing
> it).  Usually we use it to run the test suites and make sure a patch didn't
> break anything.  In this case, once the "B" turns green in the interface
> next to Linux, that means the build has finished and we can go to the build
> directory to grab binaries to run.

Also, see https://wiki.mozilla.org/Build:TryServer for more information.

Comment 10

[Tim Nguyen :ntim]

Looks like the linux builds are finished building.

Comment 11

[Brian Grinstead [:bgrins]]

Comment on attachment 8396467 [details] [diff] [review]
Patch v2

Review of attachment 8396467 [details] [diff] [review]:
-----------------------------------------------------------------

I've checked and this looks fine across all systems

Comment 12

[Brian Grinstead [:bgrins]]

Tim, you can add the checkin-needed keyword to get this checked in

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/3960ad0617ff

This landed with the wrong bug number (bug 986982).

Comment 14

[Tim Nguyen :ntim]

(In reply to Wes Kocher (:KWierso) from comment #13)
> https://hg.mozilla.org/integration/fx-team/rev/3960ad0617ff
> 
> This landed with the wrong bug number (bug 986982).

Woops, how shall I correct this ?

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/cbc96b4d39a6
Relanded with the correct bug number in https://hg.mozilla.org/integration/fx-team/rev/5b890163a973

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b890163a973