Open Bug 986973 Opened 6 years ago Updated 2 years ago

do_GetService abuse in ContentParent.cpp

Categories

(Core :: DOM: Content Processes, defect, P5)

defect

Tracking

()

People

(Reporter: neil, Unassigned)

References

Details

The code

nsCOMPtr<nsConsoleService>  consoleService(do_GetService(consoleServiceCID));

which appears ContentParent.cpp is an abuse of do_GetService, since nsConsoleService is not an interface, so what happens is that the nsIConsoleService pointer gets reinterpreted as an nsConsoleService*.

consoleService should probably be changed to an nsCOMPtr<nsIConsoleService>, and then mConsoleService should be statically cast from consoleService.get().
Blocks: 514280
Component: IPC → DOM: Content Processes
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.