987048 - console.count() toString issues are attributed to "System JS" with no filename/line number

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase 1

System JS : ERROR (null):0 - Function.prototype.toString called on incompatible object

Comment 1

[Jesse Ruderman]

Attachment: testcase 2

System JS : ERROR (null):0 - ({0:{}, 1:{}, 2:{}, 3:{}, 4:{}}) is not a function

Comment 2

[Jesse Ruderman]

Like bug 978618, this will make it hard for me to know if I come across a new bug.

Comment 3

[Bobby Holley (:bholley)]

There's some big refactoring that needs to happen for error reporting before anyone does any specific fixes for stuff like this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, the issue is that console does the toString async, not when you make the count() call, and does it from C++ code.  And in C++, for that matter.  So what were you expecting for the filename/lineno given that?

Really, this case should probably just silently do nothing or something.  There's a ClearException on the stack, but since JS is not running the JS engine decides to report the exception instead of setting a pending one or something, I guess.

In any case, we should first figure out what the right behavior is at all when ToString() throws an exception in count().  If only we had a spec here...

Comment 5

[Boris Zbarsky [:bzbarsky]]

We no longer report an exception here.  We just report a count with "no label" as the label.  Probably fixed when we moved AutoJSAPI to always take ownership of error reporting.