987101 - Switch the CrashMonitor to native OS.File.read()

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

This should be pretty simple. There is a call to NetUtil.asyncFetch used to load a file. Instead of that call, use OS.File.read.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8395957 [details] [diff] [review]
Patch

Review of attachment 8395957 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/crashmonitor/CrashMonitor.jsm
@@ +96,5 @@
>     * Load checkpoints from previous session asynchronously.
>     *
>     * @return {Promise} A promise that resolves/rejects once loading is complete
>     */
>    loadPreviousCheckpoints: function () {

Could you use a Task instead?

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Patch

Looks much clearer now ;)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8396688 [details] [diff] [review]
Patch

Review of attachment 8396688 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 6

[Carsten Book [:Tomcat]]

checked-in as https://hg.mozilla.org/integration/mozilla-inbound/rev/ab98dbf842aa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab98dbf842aa

Comment 8

[David Teller [:Yoric] - still alive but not very active]

We now need to keep watch on the startup indicators to confirm that we are not regressing.