Closed Bug 987142 Opened 8 years ago Closed 8 years ago

[Cost Control] Fix jshint erros (second part)

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mai, Assigned: mai)

References

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
jmcf
: review+
Details | Review
I want to fix some files listed in xfail.list to let our code base pass the JSHint.
Assignee: nobody → mri
Attached file patch v1.0 (obsolete) —
Hi Jose Manuel,
could you review the patch?
Regards
Attachment #8399360 - Flags: review?(jmcf)
Comment on attachment 8399360 [details] [review]
patch v1.0

Please fix the comments and the bug number and description in the commit, as it seems to be wrong

thanks!
Attachment #8399360 - Flags: review?(jmcf) → review+
Master: 53cdd2b2d8d820d242d3fbccb32c73fb2c9515b0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attached file patch v1.1
Fixed test failures on TBPL mode.
Jose, do you mind review the patch again?
Regards
Attachment #8399360 - Attachment is obsolete: true
Attachment #8400917 - Flags: review?(jmcf)
Comment on attachment 8400917 [details] [review]
patch v1.1

please land once Travis is green and the nits described on GH are fixed.

good work, thanks!
Attachment #8400917 - Flags: review?(jmcf) → review+
Master:1cfa1564cfa8b143aa71fde391be6ad5511abf1d
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Blocks: 991831
You need to log in before you can comment on or make changes to this bug.