Closed
Bug 987142
Opened 11 years ago
Closed 11 years ago
[Cost Control] Fix jshint erros (second part)
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mai, Assigned: mai)
References
Details
Attachments
(1 file, 1 obsolete file)
I want to fix some files listed in xfail.list to let our code base pass the JSHint.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mri
Assignee | ||
Comment 1•11 years ago
|
||
Hi Jose Manuel,
could you review the patch?
Regards
Attachment #8399360 -
Flags: review?(jmcf)
Comment 2•11 years ago
|
||
Comment on attachment 8399360 [details] [review]
patch v1.0
Please fix the comments and the bug number and description in the commit, as it seems to be wrong
thanks!
Attachment #8399360 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Master: 53cdd2b2d8d820d242d3fbccb32c73fb2c9515b0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 4•11 years ago
|
||
Reverted for Gaia unit test failures on TBPL.
https://github.com/mozilla-b2g/gaia/commit/6274b3645b3d41df4aa5a55398b5d106edf1c528
https://tbpl.mozilla.org/php/getParsedLog.php?id=37084706&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
Fixed test failures on TBPL mode.
Jose, do you mind review the patch again?
Regards
Attachment #8399360 -
Attachment is obsolete: true
Attachment #8400917 -
Flags: review?(jmcf)
Comment 6•11 years ago
|
||
Comment on attachment 8400917 [details] [review]
patch v1.1
please land once Travis is green and the nits described on GH are fixed.
good work, thanks!
Attachment #8400917 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Master:1cfa1564cfa8b143aa71fde391be6ad5511abf1d
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•