Open Bug 987144 Opened 11 years ago Updated 2 years ago

Clean up some of the variable names in CustomizableWidgets and refactor addShortcut

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

People

(Reporter: jaws, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P5])

From bug 986769 comment #14: I also think we should probably update some of the subview code to have clearer variable names. Note how several of the subviews are using "item" and "elem" and they're not actually the same kind of things in all cases (because really, 'item' could be anything). Finally, we could and maybe should update addShortcut to not even take an aDocument parameter. It's always the node's ownerDocument, so there's no need to pass it.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.