Closed
Bug 987160
Opened 11 years ago
Closed 11 years ago
Avoid over-reserving address ranges on windows
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.46 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
On windows we reserve 2*size, then unmap, then re-map committed with the right size. When alignment != size there are potentially many valid allocations that could be made in the reserved area. If AlignBytes grows in the opposite direction of the allocator, this will result in large holes. Instead we should reserve with size+alignment so that this is not possible.
Attachment #8395693 -
Flags: review?(jcoppeard)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8395693 [details] [diff] [review]
dont_overalloc_on_windows-v0.diff
Review of attachment 8395693 [details] [diff] [review]:
-----------------------------------------------------------------
We need |size + alignment - pageSize| to only allow one possible aligned block in the allocated region.
Attachment #8395693 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Updated.
Attachment #8395693 -
Attachment is obsolete: true
Attachment #8395833 -
Flags: review+
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•