Closed
Bug 987171
Opened 10 years ago
Closed 10 years ago
release runner attempts to tag with the same tag multiple times in some situations
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
|
2.08 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
12:09 < bhearsum> tags get extended in this loop: https://github.com/mozilla/build-tools/blob/b1638808e9c627660ddec094e35ff3af0fddd11b/buildfarm/release/release-runner.py#L314 12:10 < bhearsum> and i think we retry process_configs: https://github.com/mozilla/build-tools/blob/b1638808e9c627660ddec094e35ff3af0fddd11b/buildfarm/release/release-runner.py#L345 12:10 < bhearsum> so if something after "tags.extend" fails, you'll end up with multiple entries 12:11 < bhearsum> probably should use a set there
|
Assignee | |
Comment 1•10 years ago
|
||
I haven't tested this, but I think the code is simple enough not to fear. My new test verifies that tag() works with sets, and other than calls to it we're just creating/updating the tag set.
Assignee: nobody → bhearsum
Attachment #8395709 -
Flags: review?(rail)
|
||
Updated•10 years ago
|
Attachment #8395709 -
Flags: review?(rail) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8395709 -
Flags: checked-in+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Updated the release runner checkout. Should be fine in the future.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•