Closed Bug 987178 Opened 7 years ago Closed 7 years ago

Drop DOM_OBJECT classinfo from jsProtoHelper

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

As per bug 981845, DOM_OBJECT classinfo in JS is going away. It appears we don't really want that flag anyway as unprivileged code should not be able to receive instances of the objects in jsProtoHelper.
There don't seem to be any other instances of DOM_OBJECT for Instantbird.
Attachment #8395707 - Flags: review?(florian)
Comment on attachment 8395707 [details] [diff] [review]
Drop DOM_OBJECT classinfo from jsProtoHelper

Note: we don't pass the DOM_OBJECT flag at http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleMessage.cpp#23 :
 23 NS_IMPL_CLASSINFO(purpleMessage, NULL, 0, PURPLE_MESSAGE_CID)
(it would be instead of the "0" third parameter)
Attachment #8395707 - Flags: review?(florian) → review+
https://hg.mozilla.org/comm-central/rev/6b8380355ecd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.