987205 - Bugzilla crashes because it tries to import a non-exported login_token() subroutine from Bugzilla::Auth::Login::Cookie

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Teemu Mannermaa (:wicked)]

Automatic update of 4.4 branch install on landfill has failed. Currently the website return a software error:

-!-
Can't locate Bugzilla/Auth.pm in @INC (@INC contains: . lib/i386-linux-thread-multi lib /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.5 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.5 /usr/lib/perl5/vendor_perl /usr/lib/perl5/5.8.8/i386-linux-thread-multi /usr/lib/perl5/5.8.8) at Bugzilla.pm line 23.
BEGIN failed--compilation aborted at Bugzilla.pm line 23.
Compilation failed in require at /var/www/html/bugzilla-4.4-branch/editparams.cgi line 12.
BEGIN failed--compilation aborted at /var/www/html/bugzilla-4.4-branch/editparams.cgi line 12.
-!-

Trying to run checksetup.pl fails with following output:

-!-
* This is Bugzilla 4.4.2+ on perl 5.8.8
* Running on Linux 2.6.18-371.4.1.el5 #1 SMP Thu Jan 30 06:09:24 EST 2014

Checking perl modules...
Checking for               CGI.pm (v3.51)     ok: found v3.60
Checking for           Digest-SHA (any)       ok: found v5.71
Checking for             TimeDate (v2.23)     ok: found v2.24
Checking for             DateTime (v0.28)     ok: found v0.53
Checking for    DateTime-TimeZone (v0.71)     ok: found v1.08
Checking for                  DBI (v1.54)     ok: found v1.622
Checking for     Template-Toolkit (v2.22)     ok: found v2.22
Checking for           Email-Send (v2.04)     ok: found v2.198
Checking for           Email-MIME (v1.904)    ok: found v1.905
Checking for                  URI (v1.37)     ok: found v1.60
Checking for       List-MoreUtils (v0.32)     ok: found v0.33
Checking for    Math-Random-ISAAC (v1.0.1)    ok: found v1.004

Checking available perl DBD modules...
Checking for               DBD-Pg (v2.7.0)    ok: found v2.17.1
Checking for            DBD-mysql (v4.001)    ok: found v4.022
Checking for           DBD-SQLite (v1.29)     ok: found v1.29
Checking for           DBD-Oracle (v1.19)     ok: found v1.19

The following Perl modules are optional:
Checking for                   GD (v1.20)     ok: found v2.45
Checking for                Chart (v2.1.0)    ok: found v2.4.2
Checking for          Template-GD (any)       ok: found v1.56
Checking for           GDTextUtil (any)       ok: found v0.86
Checking for              GDGraph (any)       ok: found v1.44
Checking for           MIME-tools (v5.406)    ok: found v5.420
Checking for          libwww-perl (any)       ok: found v5.835
Checking for             XML-Twig (any)       ok: found v3.37
Checking for          PatchReader (v0.9.6)    ok: found v0.9.6
Checking for            perl-ldap (any)       ok: found v0.33
Checking for          Authen-SASL (any)       ok: found v2.15
Checking for         Net-SMTP-SSL (v1.01)     ok: found v1.01
Checking for           RadiusPerl (any)       ok: found v0.15
Checking for            SOAP-Lite (v0.712)    ok: found v0.712
Checking for          XMLRPC-Lite (v0.712)    ok: found v0.712
Checking for             JSON-RPC (any)       ok: found v0.96
Checking for              JSON-XS (v2.0)      ok: found v2.3
Checking for           Test-Taint (any)       ok: found v1.04
Checking for          HTML-Parser (v3.40)     ok: found v3.55
Checking for        HTML-Scrubber (any)       ok: found v0.08
Checking for               Encode (v2.21)     ok: found v2.47
Checking for        Encode-Detect (any)       ok: found v1.01
Checking for          Email-Reply (any)       ok: found v1.202
Checking for HTML-FormatText-WithLinks (v0.13)     ok: found v0.14
Checking for          TheSchwartz (v1.07)     ok: found v1.07
Checking for       Daemon-Generic (any)       ok: found v0.61
Checking for             mod_perl (v1.999022) ok: found v2.000004
Checking for     Apache-SizeLimit (v0.96)     ok: found v0.96
Checking for        File-MimeInfo (any)       ok: found v0.16
Checking for           IO-stringy (any)       ok: found v2.110
Checking for          mod_headers (any)       ok
Checking for          mod_expires (any)       ok
Checking for              mod_env (any)       ok
"login_token" is not exported by the Bugzilla::Auth::Login::Cookie module
Can't continue after import errors at Bugzilla/Auth/Persist/Cookie.pm line 16
BEGIN failed--compilation aborted at Bugzilla/Auth/Persist/Cookie.pm line 16.
Compilation failed in require at Bugzilla/Auth.pm line 24.
BEGIN failed--compilation aborted at Bugzilla/Auth.pm line 24.
Compilation failed in require at Bugzilla.pm line 23.
BEGIN failed--compilation aborted at Bugzilla.pm line 23.
Compilation failed in require at ./checksetup.pl line 72.
-!-

The install seems to be up to date and without conflicting local changes:

-!-
# bzr update
Tree is up to date at revision 8668 of branch bzr://bzr.mozilla.org/bugzilla/4.4
# bzr status
removed:
  extensions/MoreBugUrl/disabled
  extensions/Voting/disabled
-!-

Comment 1

[Teemu Mannermaa (:wicked)]

It seems dkl was messing with that code at bug 893195 including some problems committing it correctly for some reason. Maybe this is either regression due to that change or something got broken in the commit hassle (I hope bzr export got the changes intact).

Comment 2

[Frédéric Buclin]

Attachment: patch for trunk, v1

Comment 3

[Frédéric Buclin]

Attachment: patch for 4.4, v1

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8395776 [details] [diff] [review]
patch for trunk, v1

Review of attachment 8395776 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8395784 [details] [diff] [review]
patch for 4.4, v1

Review of attachment 8395784 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   32931bb..db8d994  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   df8716a..f5421b8  4.4 -> 4.4