987217 - Small leak in nsCreateReqFromKeyPairs

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Andrew McCreight [:mccr8]]

Attachment: leaking stack

Using LeakSanitizer, I see a small leak in a stack where nsCrypto::GenerateCRMFRequest calls nsCreateReqFromKeyPairs.  This shows up consistently in Mochitest-1.  See the attachment for details.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: patch

Thanks for finding this, Andrew. Just to check, does this patch fix the leak for you?

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 8395896 [details] [diff] [review]
patch

Review of attachment 8395896 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. We should probably file a bug to make SetCRMFRequest fail on error.

Comment 3

[Andrew McCreight [:mccr8]]

This fixes the leak for me.  Thanks!

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to Camilo Viecco (:cviecco) from comment #2)
> LGTM. We should probably file a bug to make SetCRMFRequest fail on error.

I'm not sure what you mean - I'm pretty sure SetCRMFRequest is infallible as implemented.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5931dfd4c53

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5931dfd4c53