Closed
Bug 987320
Opened 11 years ago
Closed 11 years ago
Remove unnecessary null checks for do_QueryFrame arguments
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: poiru, Assigned: poiru)
Details
Attachments
(1 file)
26.46 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Removes unnecessary null checks for do_QueryFrame arguments in cases where the null check performed by do_QueryFrame itself is sufficient.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=54b4e5a2e9fe
Attachment #8395881 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•11 years ago
|
||
Comment on attachment 8395881 [details] [diff] [review]
Remove unnecessary null checks for do_QueryFrame arguments
r=me, but for future reference a patch like this can _really_ use a diff -w in addition to the normal diff. Makes reviewing much less error-prone and hence much faster.
Attachment #8395881 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 3•11 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•