Closed Bug 987348 Opened 12 years ago Closed 12 years ago

Replace the uses of widget in the example add-ons

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

https://github.com/mozilla/addon-sdk/pull/1441
46 bytes, text/x-github-pull-request
zer0
: review+
Details | Review
We should not use sdk/widget in our example add-ons and use sdk/ui instead.
Depends on: 936623
Assignee: nobody → evold
Comment on attachment 8395973 [details] [review] https://github.com/mozilla/addon-sdk/pull/1441 `ToggleButton` needs to be used instead of `ActionButton`, when we want to attach a panel, with a bit of more "wiring" between the button and the panel, in order to keep the look & feel consistent with the rest of Firefox UI, and following the UX specs.
Attachment #8395973 - Flags: review?(zer0) → review-
Comment on attachment 8395973 [details] [review] https://github.com/mozilla/addon-sdk/pull/1441 switched from ActionButton to ToggleButton
Attachment #8395973 - Flags: review- → review?
Attachment #8395973 - Flags: review? → review?(zer0)
Attachment #8395973 - Flags: review?(zer0) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a18f20a21bf2a5a15a4de88bfedc3bcda11148fe Bug 987348 - Replace the uses of widget in the example add-ons https://github.com/mozilla/addon-sdk/commit/d2e6dd66b361179ee2fdfb07d7303bc971465480 Merge pull request #1441 from erikvold/987348 Bug 987348 - Replace the uses of widget in the example add-ons r=ZER0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: