987368 - DebuggerView doesn't destroy its editor properly

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Dave Townsend [:mossop]]

This causes the add-on debugger tests to leak.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Actually destroy the editor and drop its reference

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8395946 [details] [diff] [review]
patch rev 1

Review of attachment 8395946 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger-view.js
@@ +273,5 @@
>  
>      DebuggerController.Breakpoints.destroy().then(() => {
>        window.emit(EVENTS.EDITOR_UNLOADED, this.editor);
> +      this.editor.destroy();
> +      this.editor = null;

This should probably happen before we emit the event, no?

Comment 3

[Dave Townsend [:mossop]]

Per IRC I ignored the requested change since we pass the editor to the emitted event so we probably shouldn't destroy it first.

https://hg.mozilla.org/integration/fx-team/rev/561868618cb4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/561868618cb4

Comment 5

[u279076]

Does this need tests?

Comment 6

[Dave Townsend [:mossop]]

It's covered by automated tests.