987385 - Plugin IPC leaks in Mochitest-plain

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Andrew McCreight [:mccr8]]

Attachment: leak stacks

I don't remember seeing these before, but that just may mean that they show up now because I improved the stack.  These occur in a number of functions, such as mozilla::plugins::DeferNPObjectLastRelease, mozilla::plugins::PluginScriptableObjectChild::ScriptableEnumerate, mozilla::plugins::PPluginInstanceParent::CallNPP_HandleEvent, mozilla::plugins::PPluginModule::Reply_ProcessSomeEvents::Reply_ProcessSomeEvents.  These may actually be a number of different leaks.  The latter two look very IPC-y.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: crashtest leaks

Here are some more, in crashtests.  They are small, and look a little different than the other ones.

Comment 2

[Andrew McCreight [:mccr8]]

Some more, from M3:

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x471d41 in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:74
    #1 0x7fa341020bed in moz_xmalloc /build/memory/mozalloc/mozalloc.cpp:52
    #2 0x7fa32e07233f in operator new /build/obj-firefox/ipc/ipdl/../../dist/include/mozilla/mozalloc.h:201
    #3 0x7fa32e07233f in mozilla::plugins::PPluginModuleParent::OnCallReceived(IPC::Message const&, IPC::Message*&) /build/obj-firefox/ipc/ipdl/./PPluginModuleParent.cpp:1462
    #4 0x7fa32dbf8fdd in mozilla::ipc::MessageChannel::DispatchInterruptMessage(IPC::Message const&, unsigned long) /build/ipc/glue/MessageChannel.cpp:1217
    #5 0x7fa32dbf7139 in mozilla::ipc::MessageChannel::InterruptCall(IPC::Message*, IPC::Message*) /build/ipc/glue/MessageChannel.cpp:881

Indirect leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x471fbb in realloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:95
    #1 0x7fa32dbbb766 in Resize /build/ipc/chromium/src/base/pickle.cc:617
    #2 0x7fa32dbbb766 in Pickle::Pickle(int) /build/ipc/chromium/src/base/pickle.cc:118
    #3 0x7fa32dbca505 in IPC::Message::Message(int, unsigned int, IPC::Message::PriorityValue, IPC::Message::MessageCompression, char const*) /build/ipc/chromium/src/chrome/common/ipc_message.cc:44
    #4 0x7fa32e072363 in operator new /build/obj-firefox/ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginModule.h:993
    #5 0x7fa32e072363 in mozilla::plugins::PPluginModuleParent::OnCallReceived(IPC::Message const&, IPC::Message*&) /build/obj-firefox/ipc/ipdl/./PPluginModuleParent.cpp:1462
    #6 0x7fa32dbf8fdd in mozilla::ipc::MessageChannel::DispatchInterruptMessage(IPC::Message const&, unsigned long) /build/ipc/glue/MessageChannel.cpp:1217

Comment 3

[Georg Fritzsche [:gfritzsche]]

Do we have any documentation yet on how to build with LSAN?

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Do we have any documentation yet on how to build with LSAN?

Ah, good point, I should do that!  Basically, it is just a regular ASan build with some extra environment variables set.  See the new section I just added at the end of this Wiki article:
https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Firefox_and_Address_Sanitizer

Comment 5

[Andrew McCreight [:mccr8]]

Err, ok, the leaks are actually under PPluginInstanceParent::CallNPP_HandleEvent and PPluginModuleParent::OnCallReceived.  Some of the stacks here are kind of out of date.  These are from m3.  I'll try to narrow them down a bit.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This leak appears to be gone now. The suppression was removed in bug 1311584.