987388 - Australis - Sidebar inverted icon in menu panel is missing for Linux

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Follow up of bug 978491

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

Comment 2

[:Gijs (he/him)]

Comment on attachment 8395982 [details] [diff] [review]
Patch

Review of attachment 8395982 [details] [diff] [review]:
-----------------------------------------------------------------

Hrmpf, hg is stupid. I figured you could just do a hg cp and have a shorter / more accurate diff, but it ends up looking just the same with no copy history. :-\

Anyway, r+! :-)

Comment 3

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/a98a5b57fdc2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a98a5b57fdc2

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8395982 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 969904
User impact if declined: No inverted icon for sidebar subview on linux
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d98641e7bc1

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0

Verified fixed on Ubuntu 13.04 using Firefox 31 beta 5, build ID: 20140626181429.

Comment 8

[Francesca Ciceri [:madamezou]]

Hi,

verified fixed on Debian Linux x86_64 with Firefox 31 Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140716183446 CSet: 32dddf30405a. 
As 31 is the target milestone (and based on my testing and Cornel's one), I'm tagging this as verified, feel free to revert if that's not correct.

Cheers,
Francesca

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The issue as listed here is very obvious and should be quickly covered by Nightly users by normal browsing. Nothing we would spend time on to create a specific Mozmill test. Otherwise we would have to do the same for each and every image.