987468 - Remove "sync is delayed" notification.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

If sync is delayed, it will show a notification bar with the following strings:

error.sync.no_node_found = The Sync server is a little busy right now, but you don't need to do anything about it.  We'll start syncing your data as soon as we can!
29 error.sync.no_node_found.title = Sync Delay

Given we only want to display notifications when user action can resolve the issue, we should remove this notification.

(See also bug 979432, but it's not immediately clear which specific notification it is referring to.  Bug 985145 also mentions an unnecessary notification, but that's not referring to this one)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I'm using bug 979432 as a general tracker for "fix annoying sync notifications".

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-987468-remove-sync-delayed-notification.-r-ttaub.patch

This removes all "sync was delayed" notifications.  It also removes the strings and the sending of the weave:service:sync:delayed notification (hence feedback request on rnewman).

Try at https://tbpl.mozilla.org/?tree=Try&rev=780bd30266d3

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8398338 [details] [diff] [review]
0001-Bug-987468-remove-sync-delayed-notification.-r-ttaub.patch

Review of attachment 8398338 [details] [diff] [review]:
-----------------------------------------------------------------

Kill it with fire.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/e66a1ef084bf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e66a1ef084bf