98752 - add get_attributesForNames method to ISimpleDOMNode

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Aaron Leventhal]

GW Micro (makers of WindowEyes) has requested we add 
get_attributesForNames(numAttribs, [in] BSTR *attribNames, [in] short
*nameSpaceIDs, [out, retval] BSTR *attribValues)

The other method for getting attributes (get_attributes) returns all the
attributes, which would be wasteful if you're only looking for one or two
specific attribs.

Comment 1

[Aaron Leventhal]

Attachment: Patch

Comment 2

[John Gaunt (redfive)]

Comment on attachment 48604 [details] [diff] [review]
Patch

Looks good, I would just change this:

>+
>+  if (!domElement) 
>+    return E_FAIL;
>+

to this:

if (!domElement || !content)
  return E_FAIL;

with that change I'll give r=jgaunt

Comment 3

[John Gaunt (redfive)]

I see that GetElementAndContentFor() just does a QI of the mDOMnode to get
nsIDOMElement and nsIContent. No checks for success are made. The two interfaces
are not related and the get_attributes method checks them both. If we really can
get  by checking one or the other lets do that and clean up get_attribute, but
I'd like to know for _sure_ that is the case. 

Not to be an anal hard-ass, but good code has to start somewhere and I want to
make sure no-one looks at the accessibility code and says "Damn, I hope I never
have to touch that code" :-)

Comment 4

[Aaron Leventhal]

Attachment: Well, I always like to leave 1 little nit for you to find :P

Comment 5

[vidur (gone)]

Comment on attachment 48673 [details] [diff] [review]
Well, I always like to leave 1 little nit for you to find :P

Adding the getter in any position other than the end of the interface makes us binary incompatible with NS6.1. I know that we're not going to follow COM rules and create a new interface for the new method, but we could at least do the "right thing" by:
1) Adding the new method to the end of the existing interface.
2) Creating a new IID for the interface.
3) Letting QI succeed for both the new and the old IID, in both cases returning the same new interface.

Aaron, I'll let you make a decision on whether we care enough to do this. In either case, sr=vidur.

Comment 6

[Aaron Leventhal]

Attachment: Final version - has new IID

Comment 7

[Aaron Leventhal]

-> fix checked in