Closed
Bug 987572
Opened 11 years ago
Closed 11 years ago
BB. Visual refresh. Change hitstate color in tabbars
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(feature-b2g:2.0, tracking-b2g:backlog)
RESOLVED
FIXED
1.4 S6 (25apr)
People
(Reporter: vicky, Assigned: arnau)
References
Details
Attachments
(1 file, 1 obsolete file)
Change hitstate color for tabbars to match the new buttons hitstate (#b2f2ff).
Use white text and icons in hitstate instance.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → arnau
Blocks: 2.0-visual-refresh
Assignee | ||
Comment 1•11 years ago
|
||
Hey Pavel, I've reordered a bit the css file as it was a bit confusing finding which active state was applying in each case.
And have also changed the images in the HTML as we will give a try to SVGs.
But the main purpose of this patch is lower down the blue active state for tabs and filters (not in dark skin).
Attachment #8398504 -
Flags: review?(pivanov)
Comment 2•11 years ago
|
||
Comment on attachment 8398504 [details] [review]
patch in github
LGTM :)
Attachment #8398504 -
Flags: review?(pivanov) → review+
Updated•11 years ago
|
Target Milestone: --- → 1.4 S6 (25apr)
Updated•11 years ago
|
No longer blocks: 2.0-visual-refresh
Assignee | ||
Comment 3•11 years ago
|
||
Pavel, could you please review this patch again? I've had to redo it after the accessibility patch landed :(
Attachment #8398504 -
Attachment is obsolete: true
Attachment #8405378 -
Flags: review?(pivanov)
Comment 4•11 years ago
|
||
Comment on attachment 8405378 [details] [review]
patch in github
LGTM :)
Attachment #8405378 -
Flags: review?(pivanov) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Merged: ca0306a71e537ef101ce30136c7d7e1badee079a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•