Closed Bug 987572 Opened 7 years ago Closed 7 years ago

BB. Visual refresh. Change hitstate color in tabbars

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

RESOLVED FIXED
1.4 S6 (25apr)
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: vicky, Assigned: arnau)

References

Details

Attachments

(1 file, 1 obsolete file)

Change hitstate color for tabbars to match the new buttons hitstate (#b2f2ff).

Use white text and icons in hitstate instance.
Assignee: nobody → arnau
Blocks: 987061
Attached file patch in github (obsolete) —
Hey Pavel, I've reordered a bit the css file as it was a bit confusing finding which active state was applying in each case.
And have also changed the images in the HTML as we will give a try to SVGs.
But the main purpose of this patch is lower down the blue active state for tabs and filters (not in dark skin).
Attachment #8398504 - Flags: review?(pivanov)
Comment on attachment 8398504 [details] [review]
patch in github

LGTM :)
Attachment #8398504 - Flags: review?(pivanov) → review+
Target Milestone: --- → 1.4 S6 (25apr)
No longer blocks: 2.0-visual-refresh
Attached file patch in github
Pavel, could you please review this patch again? I've had to redo it after the accessibility patch landed :(
Attachment #8398504 - Attachment is obsolete: true
Attachment #8405378 - Flags: review?(pivanov)
Comment on attachment 8405378 [details] [review]
patch in github

LGTM :)
Attachment #8405378 - Flags: review?(pivanov) → review+
Merged: ca0306a71e537ef101ce30136c7d7e1badee079a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.