987670 - Tools Menu Copy Change

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[John Gruen [:jgruen]]

Attachment: Screen_Shot_2014-03-25_at_9_57_18_AM.png

Current tools menu says "Set Up Sync..." when user is signed out, should be updated to "Sign In To Sync..."

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Are you asking for us to distinguish the "previously signed in but am now signed out" state from the "have never signed in/don't have an account" state, or are you just suggesting that we use "Sign In to Sync" for both?

Comment 2

[John Gruen [:jgruen]]

'Sign In To Sync' for both cases. The tools menu isn't a major point for service discovery.

Comment 3

[Chris Karlof [:ckarlof]]

Ryan, do we still want to make this string change?

Comment 4

[Ryan Feeley [:rfeeley]]

Sure, we already have the string.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-987670-change-Sync-menu-copy-from-Set-Up-Sync.-t.patch

We can't reuse the existing string, but a new string is no problem.

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8647322 [details] [diff] [review]
0002-Bug-987670-change-Sync-menu-copy-from-Set-Up-Sync.-t.patch

Review of attachment 8647322 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bfe07a08a684

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfe07a08a684

Comment 9

[Forhad Hossain]

I have reproduced this bug in Nightly 31.0a1 (2014-03-25)on Windows 10 64bit.

Bug is fixed now on latest Nightly 43.0a1 (2015-08-18)(Build ID:20150818030209)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0

[bugday-20150812]

Comment 10

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced the bug with Nightly 31.0a1 (2014-03-25) on Linux x64

This Bug is now verified as fixed on Latest Firefox Nightly 43.0a1 (2015-08-18)

Build ID: 20150818030209
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

As it is also verified on Windows (Comment 9), Marking it as verified!

Comment 11

[Stefan Plewako [:stef]]

Why syncSignIn.label has ellipsis?

Comment 12

[Mark Hammond [:markh] [:mhammond]]

(In reply to Stefan Plewako [:stef] from comment #11)
> Why syncSignIn.label has ellipsis?

Because it doesn't perform the operation directly, but instead takes you to a UI where you complete the process. This is the same reason it had ellipsis before the change of wording.