987742 - Strawberry Perl requires C:\strawberry\c\bin\ to be in $ENV{PATH} to correctly load XS modules

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[louis.puttick]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

using BZ 4.4.1, strawberry perl 5.16.3, MySQL5.6, apache 2.2 on windows server 2003 sp1.

Checksetup.pl runs fine but on launching bugzilla web interface the following error is issued:
index.cgi: install_driver(mysql) failed: Can't load 'D:/Perl/perl/vendor/lib/auto/DBD/mysql/mysql.dll' for module DBD::mysql: load_file:The specified module could not be found at D:/Perl/perl/lib/DynaLoader.pm line 190.
index.cgi:  at (eval 108) line 3.
index.cgi: Compilation failed in require at (eval 108) line 3.
index.cgi: Perhaps a required shared library or dll isn't installed where expected
index.cgi:  at Bugzilla/DB.pm line 1265.


Actual results:

failed webpage


Expected results:

what should happen is that the cgi entry should find the path in perl to libmysql_.dll. The stop gap fix is to fix the problem with Strawberry Perl is to copy C:\strawberry\c\bin\libmysql_.dll to C:\strawberry\perl\vendor\lib\auto\DBD\mysql\libmysql_.dll.

many thanks to:
ihttp://lpsolit.wordpress.com/2010/05/15/installing-dbdmysql-what-a-pain/

Comment 1

[:glob ✱]

this is an issue with how perl is deployed on your system, which is outside of bugzilla's control.
you should report this issue to the strawberry perl maintainers.

Comment 2

[louis.puttick]

thanks and noted.

Comment 3

[Frédéric Buclin]

This must be documented as this is a common issue with Strawberry Perl.

Comment 4

[Frédéric Buclin]

The correct command is:

copy C:\strawberry\c\bin\libmysql__.dll C:\strawberry\perl\vendor\lib\auto\DBD\mysql\libmysql__.dll

(2 consecutive underscores, not just 1)

Comment 5

[Frédéric Buclin]

OK, scratch that! The bug is on our side. We delete $ENV{PATH} in Bugzilla::init_page() but then Strawberry Perl doesn't know where required DLL are located to load XS modules. This bug is not just about libmysql_.dll but about all DLL required by XS modules, such as libexpat-1__.dll which is required by XML::Parser, etc...

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

This is an ugly hack to make Bugzilla work with Strawberry Perl. I know that $ENV{PATH} must be sanitized per perlsec and bug 59349 (wow, Bugzilla 2.14!), but I have no idea how to make it better.

Asking justdave for review as he was heavily involved when taint checks have been implemented in Bugzilla.

Comment 7

[Frédéric Buclin]

justdave, could you tell me if you are fine with is fix, else please redirect it to another reviewer.

Comment 8

[Frédéric Buclin]

Attachment: patch, v2

Much better fix. Now I no longer guess the name of the directory in which Strawberry Perl is installed. perl.exe is in C:\...\perl\bin, and we need to also include C:\...\c\bin in the path. Tested on Windows 7.

Comment 9

[Frédéric Buclin]

This is the last patch required to make Strawberry Perl fully work with Bugzilla.

Comment 10

[Gervase Markham [:gerv]]

Comment on attachment 8667811 [details] [diff] [review]
patch, v2

Review of attachment 8667811 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv

Comment 11

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   7321534..8fff730  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   a326cd5..9cd7cb7  5.0 -> 5.0

Comment 12

[Sadiq]

I have Installed Bugzilla 5.0.1 on Windows 2008 R2 ,Strawberry Perl (64-bit) 5.22.0.1 and IIS 7.5.

Attachment issue has been fixed with this patch but one more issue has been arise after updating the patch.

Steps to produce error

1. Bugzilla Email Preferences Click disable all mail.
2. Save changes.
3. Create new bug (with or without attachment)
4. Submit bug

Error in post_bug.cgi

There was an error sending mail from 'bugzilla-daemon' to '[e-mail]': no sender
Traceback:

 at Bugzilla/Mailer.pm line 117.
	Bugzilla::Mailer::MessageToMTA(...) called at Bugzilla/BugMail.pm line 381
	Bugzilla::BugMail::sendMail(...) called at Bugzilla/BugMail.pm line 280
	Bugzilla::BugMail::Send(...) called at C:\bugzilla\post_bug.cgi line 209


I have disable all email communication so it should not try to send an email.

Regards,
Sadiq

Comment 13

[Frédéric Buclin]

(In reply to Sadiq from comment #12)
> There was an error sending mail from 'bugzilla-daemon' to '[e-mail]': no
> sender

As the error message says, 'bugzilla-daemon' is not a valid sender. It must be a valid email address. That's the reason of the error.

Comment 14

[Sadiq]

I have disable all email communication so it should not try to send an email.

It was working fine before this patch

Comment 15

[Gervase Markham [:gerv]]

I can't see how this patch could cause Bugzilla to send email in circumstances it wasn't sending it before. I would take this to the support forum; but also, try backing the patch out and seeing if that actually does cure the problem or not.

Gerv

Comment 17

[Frédéric Buclin]

I forgot to detaint $ENV{PATH} on Strawberry Perl, making graphviz unhappy.

To ssh://[e-mail]/bugzilla/bugzilla.git
   3a98ba4..a6562e0  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   6896e04..28ec15f  5.0 -> 5.0