987856 - Loop Server — Add a "X-Timestamp" header when doing 200 and 401

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

X-Timestamp

    This header will be included with all “200” and “401” responses, giving the current POSIX timestamp as seen by the server, in seconds. It may be useful for client to adjust their local clock when generating BrowserID assertions.

Comment 1

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

Comment 2

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/c29392f284c842c93bb8d7dc6b18a98f6128851c

Comment 3

[Alexis Metaireau (:alexis)]

Reopening because we don't want X- headers.

Comment 4

[Alexis Metaireau (:alexis)]

Attachment: link to github PR fixing the X- headers.

Comment 5

[Rémy Hubscher (:natim)]

Comment on attachment 8407432 [details] [review]
link to github PR fixing the X- headers.

https://github.com/mozilla-services/loop-server/commit/43ec85ec1069a0e29f4c35331e6300c332834dd0

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Out of curiosity, why don't we want any X- headers?

Comment 7

[Alexis Metaireau (:alexis)]

because that's deprecated :) http://tools.ietf.org/html/rfc6648

Comment 8

[James Bonacci [:jbonacci]]

Hmmm, interesting.... ok
We are still using them for Sync 1.5, although not X-Timestamp:
https://docs.services.mozilla.com/storage/apis-1.5.html

Comment 9

[James Bonacci [:jbonacci]]

Fix either went out with a previous deployment to Production or has been superceded by new code...