Closed Bug 987856 Opened 10 years ago Closed 10 years ago

Loop Server — Add a "X-Timestamp" header when doing 200 and 401

Categories

(Hello (Loop) :: Server, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: rhubscher)

References

Details

Attachments

(2 files)

X-Timestamp

    This header will be included with all “200” and “401” responses, giving the current POSIX timestamp as seen by the server, in seconds. It may be useful for client to adjust their local clock when generating BrowserID assertions.
Blocks: loop_mvp
No longer blocks: loop_mlp
Attached file Link to GitHub PR.
Attachment #8406900 - Flags: review?(alexis+bugs)
Status: NEW → ASSIGNED
Assignee: nobody → rhubscher
Attachment #8406900 - Flags: review?(nperriault)
https://github.com/mozilla-services/loop-server/commit/c29392f284c842c93bb8d7dc6b18a98f6128851c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reopening because we don't want X- headers.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8407432 - Flags: review?(nperriault)
Attachment #8406900 - Flags: review?(nperriault)
Attachment #8406900 - Flags: review?(alexis+bugs)
Attachment #8406900 - Flags: review+
Comment on attachment 8407432 [details] [review]
link to github PR fixing the X- headers.

https://github.com/mozilla-services/loop-server/commit/43ec85ec1069a0e29f4c35331e6300c332834dd0
Attachment #8407432 - Flags: review?(nperriault) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Out of curiosity, why don't we want any X- headers?
because that's deprecated :) http://tools.ietf.org/html/rfc6648
Hmmm, interesting.... ok
We are still using them for Sync 1.5, although not X-Timestamp:
https://docs.services.mozilla.com/storage/apis-1.5.html
Fix either went out with a previous deployment to Production or has been superceded by new code...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: