Closed Bug 987929 Opened 6 years ago Closed 2 years ago

Private browsing indicator can overlap with icons in the tabstrip when using Private Tab add-on

Categories

(WebExtensions :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mconley, Unassigned)

References

()

Details

(Whiteboard: [Australis:P-])

STR:

1) Enter customize mode
2) Put an item into the tabstrip to the right of the new tab button and the all tabs dropdown.
3) Exit customize mode.
4) Open a private browsing window

AR:

The item moved to the tabstrip overlaps the private browsing indicator.

ER:

The item should not overlap the private browsing indicator - there should be a gap separating them.

Please see https://bug940509.bugzilla.mozilla.org/attachment.cgi?id=8396635
Status: NEW → ASSIGNED
Hrm. These STR don't work for me with the latest build of Firefox 29 beta2.

I can't seem to reproduce this at all. Tim, do you have STR for a blank profile?
Flags: needinfo?(tmeader)
Okay, this appears that it might only occur for those of us using this addon:

https://addons.mozilla.org/en-US/firefox/addon/private-tab/?src=api

Not a default behavior problem obviously, but you can easily reproduce if you install that. After installing, you can either hit Ctrl+Alt+T to switch to a Private Tab, or add the button that will allow you to open a new private tab directly. Right-click menu on a tab will also allow you to switch it to "private". Any of these actions will trigger the behavior.

This is likely just an addon issue though that hopefully they can fix.
Flags: needinfo?(tmeader)
Yep, confirmed that this is due to the private tab add-on.

That add-on needs to resize the caption button placeholder in the tabstrip so that this is prevented, much like we do here:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4546:

4542       // Finally, size the placeholders:
4543 #ifdef XP_MACOSX
4544       this._sizePlaceholder("fullscreen-button", fullscreenButtonWidth);
4545 #endif
4546       this._sizePlaceholder("caption-buttons", captionButtonsBoxWidth);

Over to Tech Evangelism for add-on compat.
Assignee: mconley → nobody
Component: Theme → Add-ons
Product: Firefox → Tech Evangelism
Summary: Private browsing indicator can overlap with icons in the tabstrip → Private browsing indicator can overlap with icons in the tabstrip when using Private Tab add-on
Whiteboard: [Australis:P3] → [Australis:P-]
Status: ASSIGNED → NEW
The developer has been notified.
(In reply to Mike Conley (:mconley) from comment #3)
> Yep, confirmed that this is due to the private tab add-on.
> 
> That add-on needs to resize the caption button placeholder in the tabstrip
> so that this is prevented, much like we do here:
> 
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.
> js#4546:
> 
> 4542       // Finally, size the placeholders:
> 4543 #ifdef XP_MACOSX
> 4544       this._sizePlaceholder("fullscreen-button", fullscreenButtonWidth);
> 4545 #endif
> 4546       this._sizePlaceholder("caption-buttons", captionButtonsBoxWidth);
> 
> Over to Tech Evangelism for add-on compat.

This is already corrected in development version:
https://github.com/Infocatcher/Private_Tab/commit/b987ea014dd3ea8881fd4721695ccca47caad70d
But still buggy with this new private mode indicator because the height is also should be (somehow) corrected.
OK, I called whole TabsInTitlebar._update(true) instead:
https://github.com/Infocatcher/Private_Tab/commit/6c43c74e859741ec3f5ebb13c712b843eff68517
Better, but I see some visual glitches during update sometimes. :(
Should be fixed in new version: https://addons.mozilla.org/addon/private-tab/versions/0.1.7.1

Also my glitches was caused by non-standard height of window title (and yes, it's customizable using only built-in options, at least on Windows XP and 7).
Mass-closing bugs that relate to legacy versions of add-ons or are otherwise no longer worth tracking. Please comment if you think this bug should be reopened.

Sorry for the bugspam. Made you look, though!
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.