Closed Bug 988010 Opened 7 years ago Closed 7 years ago

multilocale build tests failing with a maxBuffer exceeded error

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S5 (11apr)
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: djf, Unassigned)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
dmarcos
: review+
yurenju
: feedback+
Details | Review
When we tried to merge camera app changes into master, we found that completely unrelated multilocale build tests were failing, apparently because the output of the gaia build process has become so large that Node's maxBuffer size was being exceeded.

We'll try to fix that just by including an explicit maxBuffer size in the call to exec() in the multilocale test.
Diego,

If this fixes the test failure, please give r+ and land it with the rest of the camera features.

Yuren: I'm setting feedback? for you just to bring this to your attention, since I think youre the owner of these tests.
Attachment #8396721 - Flags: review?(dmarcos)
Attachment #8396721 - Flags: feedback?(yurenju.mozilla)
Attachment #8396721 - Flags: review?(dmarcos) → review+
Comment on attachment 8396721 [details] [review]
link to github pull request

okay, thanks for remind me!
Attachment #8396721 - Flags: feedback?(yurenju.mozilla) → feedback+
The PR was not merged normally on github, but the commit was included in this mega-PR: https://github.com/mozilla-b2g/gaia/pull/17599/commits 

So it has landed on master.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in before you can comment on or make changes to this bug.