988023 - telemetry on how often we hit search service synchronous fallback

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 722332 added an async initialization to the search service that avoids main thread IO, and most big consumers have been moved over to it (apart from the remaining ones tracked in bug 987715). Bug 987715 suggests that we still do a bunch of search service-related main thread I/O, though, so it's possible many add-ons are causing us to hit this path (or we forgot to update a consumer somewhere).

Some telemetry that measures how often the synchronous fallback is hit would be useful.

http://hg.mozilla.org/mozilla-central/annotate/c69c55582faa/toolkit/components/search/nsSearchService.js#l2899

Comment 1

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: telemetry on how often we hit search service synchronous fallback, v1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8421076 [details] [diff] [review]
telemetry on how often we hit search service synchronous fallback, v1

don't see much point to the "telemetry" temp variable, just inline the reference to Services.telemetry?

Thanks!

Comment 3

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: telemetry on how often we hit search service synchronous fallback, v2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2ef4f2ba78b4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ef4f2ba78b4