Make --enable-debug gecko device builds for B2G



5 years ago
a year ago


(Reporter: gwagner, Assigned: aki)



Firefox Tracking Flags

(tracking-b2g:backlog, b2g-v1.4 fixed, b2g-v2.0 fixed)



(3 attachments, 1 obsolete attachment)



5 years ago
Can we get a device build with debug gecko enabled?
I don't think we need a per-commit build. MC granularity with multiple builds per day would be enough.

It would help a lot if QA has access to debug builds so we can have regression ranges for debug-only assertions.

Comment 1

5 years ago
Would we need this in addition to debug desktop builds or instead of? bug 956451
Flags: needinfo?(anygregor)

Comment 2

5 years ago
That's in addition.
Basically QA should be able to flash a phone with a debug-gecko version.
So for device builds we just have to add the --enable-debug flag in the mozconfig.
Flags: needinfo?(anygregor)

Comment 4

5 years ago
As discussed on IRC we will try to reuse existing emulator gecko builds. We need to package them so they are downloadable and easy to install on a device.
Flags: needinfo?(anygregor)

Comment 5

5 years ago
Posted patch emu-nightly-tbpl (obsolete) — Splinter Review
I'm not 100% sure about this patch, but it looks like it might work...
Assignee: nobody → aki
Attachment #8397493 - Flags: review?(ryanvm)

Comment 6

5 years ago
Attachment #8397499 - Flags: review?(catlee)

Comment 7

5 years ago
Posted patch emu-nightlySplinter Review
Adds these builders.  This is because depend builds don't do the public upload.

> b2g_mozilla-central_emulator_nightly ScriptFactory
> b2g_mozilla-central_emulator-debug_nightly ScriptFactory
> b2g_mozilla-central_emulator-jb_nightly ScriptFactory
> b2g_mozilla-central_emulator-jb-debug_nightly ScriptFactory
> b2g_mozilla-central_emulator-kk_nightly ScriptFactory
> b2g_mozilla-central_emulator-kk-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-jb_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-jb-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-kk_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-kk-debug_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-debug_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-jb_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-jb-debug_nightly ScriptFactory
Attachment #8397500 - Flags: review?(catlee)
Comment on attachment 8397493 [details] [diff] [review]

Review of attachment 8397493 [details] [diff] [review]:

You shouldn't need the debug special-casing (just the plain Nightly lines should suffice). Emulator debug builds/tests are already recognized properly as a different flavor, so nightlies should be no different. Assuming the ASAN ones above it are what's confusing about it, those are a special-case where we want to display the debug build on the same line as the other ASAN builds rather than on their own separate line.

::: js/Data.js
@@ +644,5 @@
>          /b2g.*_tarako_nightly/i.test(name) ? "Tarako Device Image Nightly" :
>          /b2g.*_unagi_nightly/i.test(name) ? "Unagi Device Image Nightly" :
>          /b2g.*_wasabi_nightly/i.test(name) ? "Wasabi Device Image Nightly" :
> +        /b2g.*_emulator.*_debug_nightly/i.test(name) ? "Emulator Device Image Debug Nightly" :
> +        /b2g.*_emulator.*_nightly/i.test(name) ? "Emulator Device Image Nightly" :

Please put this above the Hamachi line to follow the same pattern as the dep builds.
Attachment #8397493 - Flags: review?(ryanvm) → review-
Also, TBPL should work as-is for the device image debug builds without any further changes being necessary.
Attachment #8397499 - Flags: review?(catlee) → review+
Attachment #8397500 - Flags: review?(catlee) → review+

Comment 10

5 years ago
Attachment #8397493 - Attachment is obsolete: true
Attachment #8397978 - Flags: review?(ryanvm)
Attachment #8397978 - Flags: review?(ryanvm) → review+


5 years ago
Keywords: leave-open

Comment 14

5 years ago
If we want these emulator debug gecko packages uploaded, I'll need to land on all live mozilla-b2g* branches and mozilla-aurora.
blocking-b2g: --- → 1.3?

Comment 15

5 years ago
Live in production.
This is a good idea, but this won't block 1.3.
blocking-b2g: 1.3? → backlog
Depends on: 989154
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17)
> (In reply to Aki Sasaki [:aki] from comment #11)
> >

In production :)

Comment 20

5 years ago
Which branches do we need this on?  i.e. which b2g versions?
Flags: needinfo?(anygregor)

Comment 21

5 years ago
(In reply to Aki Sasaki [:aki] from comment #20)
> Which branches do we need this on?  i.e. which b2g versions?

Can we do trunk and 1.4? 1.4 should be aurora.
Thanks for the quick turnaround!
Flags: needinfo?(anygregor)


5 years ago
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 22

5 years ago
Ok, these are getting uploaded to ftp.

The problem with using or is that the package names are the same for emulator, emulator-jb, and emulator-kk, so we only get one of them in those directories, and it's not clear which one.

There are tinderbox-builds uploads which fix this:

If we want to be able to use the nightly upload dirs, we can potentially rename the packages.
blocking-b2g: backlog → ---
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.