988088 - Cache path objects in Path2D implementation

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Rik Cabanier]

Currently, the path object is recreated each time it is used in a canvas call.
This causes unnecessary overhead since the path likely is cached and won't change.

Comment 1

[Rik Cabanier]

Attachment: Implementation of path cache in Path2D

Comment 2

[Rik Cabanier]

try build: https://tbpl.mozilla.org/?tree=Try&rev=8a48f7166f16

Comment 3

[Rik Cabanier]

Attachment: Implementation of path cache in Path2D

Comment 4

[Rik Cabanier]

Comment on attachment 8396815 [details] [diff] [review]
Implementation of path cache in Path2D

try build: https://tbpl.mozilla.org/?tree=Try&rev=7c8ceff33730
Previous submit had a logic error that was caught on Windows.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8397155 [details] [diff] [review]
Implementation of path cache in Path2D

Review of attachment 8397155 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/CanvasRenderingContext2D.cpp
@@ +4547,4 @@
>  }
>  
> +void
> +CanvasPath::ensurePathBuilder() const

"EnsurePathBuilder"

@@ +4555,5 @@
> +
> +  // if there is not pathbuilder, there must be a path
> +  MOZ_ASSERT(mPath);
> +  mPathBuilder = mPath->CopyToBuilder();
> +  mPath = NULL;

nullptr

Comment 6

[Rik Cabanier]

Attachment: 8397155: Implementation of path cache in Path2D

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9204362c5122

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9204362c5122

Comment 9

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> 9204362c5122 Bug 988088 - Cache path objects in Path2D implementation. r=bas

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central