988095 - Log more details about verifier-related errors

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Token, defect, P1)

Description

[Ryan Kelly [:rfkelly]]

Currently the tokenserver will log ConnectionError's from the remove verifier like thisL

  {
    "severity": 6,
    "timestamp": "2014-03-26T00:13:51.161667Z",
    "metlog_hostname": "ip-10-153-139-114",
    "fields": {
        "rate": 1.0,
        "name": "token.assertion.connection_error"
    },
    "metlog_pid": 2266,
    "logger": "",
    "type": "counter",
    "payload": "1",
    "env_version": "0.8"
  }

This is really not that helpful, we should log a full traceback for any unexpected errors like this.

Comment 1

[James Bonacci [:jbonacci]]

See also https://github.com/mozilla/browserid-verifier/issues/24

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: ts-log-traceback-for-verifier-errors.diff

This patch adds a traceback log for an non-trust-related verifier errors.  It also cleans up the verifier error-handling a bit, e.g. moving it out of a pointless helper function and checking classes rather than checking the string name of the error.

Comment 3

[Ryan Kelly [:rfkelly]]

Comment on attachment 8442636 [details] [diff] [review]
ts-log-traceback-for-verifier-errors.diff

Actually, Tarek if you get a change to sanity-check this for me today, I can get a new tag done for further testing tomorrow.

Comment 4

[Ryan Kelly [:rfkelly]]

Thanks Tarek!

https://github.com/mozilla-services/tokenserver/commit/7be287a36e9135299e4a57bae76b8d49117e560c

Comment 5

[James Bonacci [:jbonacci]]

It's out there:
Stage Deploy: bug 1014496
Prod Deploy: bug 1027899